Place incorporation date and state fields in the Company information form on separate rows to avoid overflowing labels #5923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dal-Papa
approved these changes
Oct 18, 2021
|
Bump @Gonals :) |
Gonals
approved these changes
Oct 19, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 19, 2021
…-and-date-fields Place incorporation date and state fields in the Company information form on separate rows to avoid overflowing labels (cherry picked from commit c7812ac)
|
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.8-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
@roryabraham We retested this on Web, Android, mWeb and Desktop and it was a pass! Looks like iOS failed and that's why we haven't received the 1.1.8-5 build. |
|
Verified on iOS |
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fix the overflowing labels for the Spanish translations of the
Incorporation dateandIncorporation stateby having each field on a separate row instead of on the same row.Fixed Issues
(Partially fixes) #5904
Tests/ QA Steps
/bank-account/companyor Workspace > Connect bank accountTested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android