Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging label isfloating right instead of 8px right to the ´Chat´ header #6297

Closed
isagoico opened this issue Nov 15, 2021 · 5 comments
Closed
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to NewDot
  2. Log in to any account.

Expected Result:

Staging label is floating left 8px right to the ´Chat´ header

Actual Result:

Staging label is floating right instead of 8px right to the ´Chat´ header

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.14-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
Captura de pantalla 2021-11-15 a las 12 03 36

Expensify/Expensify Issue URL:

Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1636732354165700

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

parasharrajat commented Nov 15, 2021

A recent 2 months old 😃 change to the sidebar styling broke this 83c9007.

Proposal

We can simply fix this by removing the flex1 styling from the nested column.

<View style={[styles.flex1, styles.flexColumn]}>

It can simply be View without styling as the default axis for View is column in RN.

@bondydaa
Copy link
Contributor

looks the discussion is happening https://expensify.slack.com/archives/C01GTK53T8Q/p1636732354165700 there might be more issues with some styles as well.

Not sure if we need 1 big GH track them all or if we just want to create GHs as they pop up.

@bondydaa bondydaa assigned marcochavezf and unassigned bondydaa Nov 15, 2021
@bondydaa bondydaa added Improvement Item broken or needs improvement. and removed Company Offsite Hold labels Nov 15, 2021
@bondydaa
Copy link
Contributor

Going to assign to Marco, our SOP is to typically have the engineer fix whatever they broke but this could probably also go to a contributor as well.

@marcochavezf marcochavezf mentioned this issue Nov 16, 2021
5 tasks
@marcochavezf
Copy link
Contributor

I created this PR to fix the label position. I added that View before for the VBA step counter, I tested the solution and look good in both places (badge and step counter):

Screen Shot 2021-11-16 at 14 00 46

Screen Shot 2021-11-16 at 14 05 14

@marcochavezf marcochavezf added the Reviewing Has a PR in review label Nov 16, 2021
@botify botify closed this as completed Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants