Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style in Header #6334

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Fix style in Header #6334

merged 1 commit into from
Nov 16, 2021

Conversation

marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Nov 16, 2021

Details

This PR removes an extra style in the header which was introduced in the VBA step counter.

Fixed Issues

$ #6297

Tests / QA Steps

Open the app and check the DEV/STG badge is near to the avatar icon.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-11-16 at 14 11 35

Mobile Web

Screen Shot 2021-11-16 at 14 11 55

Desktop

Screen Shot 2021-11-16 at 15 05 40

iOS

Screen Shot 2021-11-16 at 13 59 00

Android

Screen Shot 2021-11-16 at 14 05 28

@marcochavezf marcochavezf requested a review from a team as a code owner November 16, 2021 19:06
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team November 16, 2021 19:07
@marcochavezf marcochavezf self-assigned this Nov 16, 2021
@Jag96
Copy link
Contributor

Jag96 commented Nov 16, 2021

e2e is being weird here, seems like everything is done but Travis is stuck
image

Going to merge instead of restarting the tests.

@Jag96 Jag96 merged commit 339bb67 into main Nov 16, 2021
@Jag96 Jag96 deleted the marco-fixStyleHeader branch November 16, 2021 20:07
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants