Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - LHN does not show [Comment deleted] for the user after deleting the message #6422

Closed
kavimuru opened this issue Nov 23, 2021 · 7 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Nov 23, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #4133

Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Send the message
  4. Go back to LHN and check the message
  5. Back to user you sent message and delete it.

Expected Result:

The LHN shows "[Comment deleted]" for that user

Actual Result:

The LHN doesn't show "[Comment deleted]"

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.16-1
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Issue was found when executing #4133

Issue reproducible occasionally.

Bug5341146_Screen_Recording_20211122-205501_New_Expensify.mp4
Bug5341146_Screen_Recording_20211122-210144_New_Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Nov 23, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Beamanator
Copy link
Contributor

I wonder if this could be related to the change for this issue: #3293

@parasharrajat
Copy link
Member

Yeah, Actually, it would have been solved by #3293.

@dklymenk
Copy link
Contributor

Hi, I am the author of the mentioned PR. Thanks for raising the issue, but I can't seem to reproduce it. Is there more to it than just android? Here is video from android on dev mode:

6422.mp4

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Nov 24, 2021

I am also unable to reproduce the issue on Android simulator

@isagoico
Copy link

I'm unable to reproduce this on Android on build 1.1.16-6, I think we're good to close it out
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants