Deploy Checklist: New Expensify 2021-11-22

[OSBotify]

Release Version: 1.1.16-10
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Animations for the IOU flow #4070

  • QA
  • Accessibility

• Reverting 3979 #4085

  • QA
  • Accessibility

• Revert "Merge pull request #4085 from Expensify/chirag-revert-3979" #4133

  • QA
  • Accessibility

• Update "be the first person to comment" screen #4921

  • QA
  • Accessibility

• fix: Change password hint color to red when invalid, else grey #5130

  • QA
  • Accessibility

• Updated logic to Not allow future date as incorporation date #5939

  • QA
  • Accessibility

• check if reports data is up to date before update last read action id #6095

  • QA
  • Accessibility

• Wrap PDF in TouchableWithoutFeedback #6169

  • QA
  • Accessibility

• Request Call placeholder & messages updated #6178

  • QA
  • Accessibility

• Unescape the backend strings for IOU #6184

  • QA
  • Accessibility

• Date Picker Restriction Added for company step VBA #6192

  • QA
  • Accessibility

• [No QA] Ensure bundle version strings are compatible before auto-merging CP PR #6199

  • QA
  • Accessibility

• Update the proposal flow to indicate GH should be checked first #6245

  • QA
  • Accessibility

• Remove deleted messages from the unread message count #6248

  • QA
  • Accessibility

• Remove Negative margin to fix the cropped action buttons #6249

  • QA
  • Accessibility

• Fix inverted list by applying forked version of react-native-web #6268

  • QA
  • Accessibility

• Compare against null because sequenceNumber can be 0 #6275

  • QA
  • Accessibility

• Resolve issue with pdf attachment not being scrollable in preview page before sending on Android #6276

  • QA
  • Accessibility

• Restricted workspace create button click while workspace is created. #6280

  • QA
  • Accessibility

• iPhoneX Landscape UI #6291

  • QA
  • Accessibility

• Added download links to the workspace invite message #6292

  • QA
  • Accessibility

• Allow spaces and special chars in phone number username #6293

  • QA
  • Accessibility

• Fix back handler for Android #6295

  • QA
  • Accessibility

• Revert "Deep link to add secondary login in OldDot" #6313

  • QA
  • Accessibility

• Deep link to add secondary login in OldDot #6319

  • QA
  • Accessibility

• URL PATH REGEX improved to match any link #6320

  • QA
  • Accessibility

• Fix blank screen displayed on Company Step VBA flow #6327

  • QA
  • Accessibility

• Fix: clicking on makerbadge does not mark comments as read #6328

  • QA
  • Accessibility

• Allow dropdown arrow to be clicked on select inputs #6329

  • QA
  • Accessibility

• Fix switching to manual address when adding bank account #6332

  • QA
  • Accessibility

• Remove animations from the Popover menus #6333

  • QA
  • Accessibility

• Fix style in Header #6334

  • QA
  • Accessibility

• Fix avatar warning for incorrect propType #6336

  • QA
  • Accessibility

• Remove early return from isFromPublicDomain if domain is public #6340

  • QA
  • Accessibility

• Pass translateX prop to TextInput component #6341

  • QA
  • Accessibility

• [No QA] Run CP workflow on macOS #6344

  • QA
  • Accessibility

• Fix : Pressing Tab button in AddressSearch inputs #6345

  • QA
  • Accessibility

• Updated copy for Issue corporate cards page #6346

  • QA
  • Accessibility

• Update expensify system emails #6347

  • QA
  • Accessibility

• wen-fix-square-room-avatar #6348

  • QA
  • Accessibility

• Revert "[No QA] Ensure bundle version strings are compatible before auto-merging CP PR" #6350

  • QA
  • Accessibility

• Revert "[No QA] Run CP workflow on macOS" #6352

  • QA
  • Accessibility

• force recalculation of drawer on orientation change #6356

  • QA
  • Accessibility

• Update Plaid Link Component #6362

  • QA
  • Accessibility

• Add /partners/plaid/oauth_ios to apple-app-site-association #6366

  • QA
  • Accessibility

• [NO QA]Sign commits for @OSBotify #6368

  • QA
  • Accessibility

• [NO QA]Import from the GPG key from the right directory #6371

  • QA
  • Accessibility

• [No QA] Update botify workflows to use new signing key #6374

  • QA
  • Accessibility

• [NO QA]Checkout Cherry Pick using OS_BOTIFY_TOKEN #6377

  • QA
  • Accessibility

• [NO QA]Update one more instance of GITHUB_TOKEN to use OS_BOTIFY_TOKEN #6379

  • QA
  • Accessibility

• [No QA] Dummy change to test CP #6381

  • QA
  • Accessibility

• Update the Apple app association file #6385

  • QA
  • Accessibility

• Revert signing of commits of OSBotify #6395

  • QA
  • Accessibility

• [No QA] Update webpack path for apple app association #6408

  • QA
  • Accessibility

• Fix IOU Modal styles. #6417

  • QA
  • Accessibility

• Strip prefix and translate pronouns when needed #6419

  • QA
  • Accessibility

• fix: Secondary login page #6433

  • QA
  • Accessibility

• Revert "Merge pull request #6268 from azimgd/fix-inverted-list" #6441

  • QA
  • Accessibility

• remove deleted comment message on new chats #6458

  • QA
  • Accessibility

• fix: newline via updating the count first before marking the messages as read #6459

  • QA
  • Accessibility

• Encode secondary login URL #6479

  • QA
  • Accessibility

Internal QA:

• Update README.md #6365 -

Deploy Blockers:

• Profile - Unable to add symbols or spaces when adding phone number as secondary login #6414
• [HOLD for payment 2021-12-13] [HOLD for payment 2021-12-06] IOU - "Request $xx" button appears at the top of the page #6415
• Chat - Empty chat will show a pronoun placeholder #6416
• Chat - LHN does not show [Comment deleted] for the user after deleting the message #6422
• Chat - Green line does not appear when receiving a new message, but appears in the chat when sending a message #6424
• Visual issues when scrolling - Reported by: @parasharrajat #6425
• Chat - LHN displayed as "comment deleted" for the new user when initiating chat and navigating to LHN  #6426
• Chat messages are fixed top instead of bottom - Reported by: @PrashantMangukiya  #6436
• [$250] iOS - VBA - Unable to see dates clearly or missing altogether in company /personal info page #6438
• "Add work email address" button doesn't show up and text copy is not the correct one  #6439
• Android - VBA - User could not add bank account using plaid option #6457
• iOS - VBA - User not directed with the secondary login model open tapping "Add work" email #6475

cc @Expensify/applauseleads

[MelvinBot]

📣 @applausebot You have been assigned to this job by @OSBotify!
Please apply to this job in Upwork and let us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[isagoico]

Lol melvinbot is confused here 😆
Starting QA 🚀

[roryabraham]

WOW that's a lot of deploy blockers.

[isagoico]

Currently testing these CPs in all environments:

• Revert "Merge pull request #6268 from azimgd/fix-inverted-list" #6441
• fix: Secondary login page #6433
• Fix IOU Modal styles. #6417
• Deep link to add secondary login in OldDot #6319

[isagoico]

Regression is almost finished! Summary of what we have found so far:

• Revert "Merge pull request #4085 from Expensify/chirag-revert-3979" #4133 - Is failing because of Chat - LHN does not show [Comment deleted] for the user after deleting the message #6422 and Chat - LHN displayed as "comment deleted" for the new user when initiating chat and navigating to LHN  #6426
• Allow spaces and special chars in phone number username #6293 - Was failing because of Profile - Unable to add symbols or spaces when adding phone number as secondary login #6414 (Being retested fix: Secondary login page #6433)
• Deep link to add secondary login in OldDot #6319 was failing because of "Add work email address" button doesn't show up and text copy is not the correct one  #6439 (being retested atm)

Comments:

1. Update Plaid Link Component #6362 (comment) - Resolved

List of issues found so far:

• Chat - Empty chat will show a pronoun placeholder #6416
• [$250] iOS - VBA - Unable to see dates clearly or missing altogether in company /personal info page #6438
• "Add work email address" button doesn't show up and text copy is not the correct one  #6439
• Profile - Messaging an account not created will display an unconfirmed time zone #6428
• [HOLD for payment 2022-02-01] $1000 - IOU - Decimal separator not updated when set to Spanish on some screens #6427
• Chat - LHN displayed as "comment deleted" for the new user when initiating chat and navigating to LHN  #6426
• Chat - Green line does not appear when receiving a new message, but appears in the chat when sending a message #6424
• Chat - LHN does not show [Comment deleted] for the user after deleting the message #6422
• Chat - Empty chat will show a pronoun placeholder #6416
• [HOLD for payment 2021-12-13] [HOLD for payment 2021-12-06] IOU - "Request $xx" button appears at the top of the page #6415
• Profile - Unable to add symbols or spaces when adding phone number as secondary login #6414

CPs being tested at the moment #6399 (comment).

Thanks!

[isagoico]

Checked off the Deploy blockers that have been fixed and retested. Only deploy blockers left to fix and retest are

• Chat - Green line does not appear when receiving a new message, but appears in the chat when sending a message #6424
• Chat - LHN displayed as "comment deleted" for the new user when initiating chat and navigating to LHN  #6426
• Android - VBA - User could not add bank account using plaid option #6457

[isagoico]

Testing these CP atm:

• fix: newline via updating the count first before marking the messages as read #6459 (Fixes Chat - Green line does not appear when receiving a new message, but appears in the chat when sending a message #6424)
• remove deleted comment message on new chats #6458 (Fixes Chat - LHN displayed as "comment deleted" for the new user when initiating chat and navigating to LHN  #6426)

[isagoico]

We found a issue when executing QA for PR #6319 on iOS - #6475 (tagged @luacmartins on PR so he can give it a look)

[luacmartins]

Fix for #6475 is up - #6479

[isagoico]

Checking off #6479 (comment)! It was a pass 🎉

[roryabraham]

@yuwenmemon @tgolen I'm going to check off #6365, looks like it shouldn't block our deploy here.

[roryabraham]