[HOLD for payment 2022-01-27] Update copy used in ValidationStep when bank account is verifying

[rosegrech]

Problem

From this GH, noticed some punctuation items that should be corrected. See the solution for the deets.

Solution

In this screenshot, there seem to be some small punctuation issues to address:

• We use "!" 3x times which we try to avoid in such short copy.
• "No, let's start over" has no punctuation where the previous action has "!". We should be consistent in punctuation use not only in the same view/screen but throughout the platform. I have no clue if we use punctuations for such areas. If so, let's use "." vs "!".
• Suggested copy tweak as the "but" was not sounding great to my ears :)

Thanks for doing that! Now, we just need your help verifying some info, which we can work out quickly over chat. Ready?

In this screenshot, we should have periods "." at the end of each sentence.

[MelvinBot]

Triggered auto assignment to @JmillsExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

Current assignee @JmillsExpensify is eligible for the AutoAssignerTriage assigner, not assigning anyone new.

[MelvinBot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[mdneyazahmad]

Proposal

We need to make these changes.

1. No change
   

   App/src/languages/en.js

   Line 793 in a87b53c

   letsFinishInChat: 'Let\'s finish in chat!',

Spanish

letsFinishInChat: '¡Continuemos en el chat!',

2 Remove ! mark in the end

App/src/languages/en.js

Line 652 in a87b53c

letsChatCTA: 'Yes, let\'s chat!',

Spanish

-letsChatCTA: '¡Sí, vamos a chatear!',
+letsChatCTA: 'Sí, vamos a chatear',

3. No change
   

   App/src/languages/en.js

   Line 796 in a87b53c

   noLetsStartOver: 'No, let\'s start over',

Spanish

noLetsStartOver: 'No, empecemos de nuevo',

4. Change ! to . (period)
   

   App/src/languages/en.js

   Line 653 in a87b53c

   letsChatText: 'Thanks for doing that! We need your help verifying a few pieces of information, but we can work this out quickly over chat. Ready?',

Spanish

-letsChatText: '¡Gracias! Necesitamos tu ayuda para verificar la información, pero podemos hacerlo rápidamente a través del chat. ¿Estás listo?',

+letsChatText: 'Gracias Necesitamos tu ayuda para verificar la información, pero podemos hacerlo rápidamente a través del chat. ¿Estás listo?',

5. Add .(period) in the end
   

   App/src/languages/en.js

   Line 648 in a87b53c

   description: 'A day or two after you add your account to Expensify we send three (3) transactions to your account. They have a merchant line like "Expensify, Inc. Validation"',

Spanish

-description: 'Uno o dos días después de agregar su cuenta a Expensify, enviamos tres (3) transacciones a su cuenta. Tienen una línea comercial como "Expensify, Inc. Validation"',
+description: 'Uno o dos días después de agregar su cuenta a Expensify, enviamos tres (3) transacciones a su cuenta. Tienen una línea comercial como "Expensify, Inc. Validation."',

6. Add .(period) in the end
   

   App/src/languages/en.js

   Line 649 in a87b53c

   descriptionCTA: 'Please enter each transaction amount in the fields below. Example: 1.51',

Spanish

-descriptionCTA: 'Please enter each transaction amount in the fields below. Example: 1.51',
+descriptionCTA: 'Please enter each transaction amount in the fields below. Example: 1.51.',

[rosegrech]

Yup and additionally this copy change for the first screenshot:

Thanks for doing that! Now, we just need your help verifying some info, which we can work out quickly over chat. Ready?

[marcaaron]

Hey @rosegrech seems like we already have an issue for the header text here #6900

Can we change this issue title to something else to be sure the other changes you are suggesting get addressed separately? We now have two issues that are both proposing similar issues with their titles.

[rosegrech]

sure thing. I have no clue what to call it though which is why I used similar text but have the beginning different

[marcaaron]

gotchu!

[JmillsExpensify]

Sorry for the delay! Catching on my next steps now.

[JmillsExpensify]

Issue looks good with Marc's suggestion (e.g. clarifying the updates outside the header). I've also posted the job to Upwork here: https://www.upwork.com/jobs/~0128c8d14a0f1522c5.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Triggered auto assignment to @AndrewGable (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

@mdneyazahmad I believe you need to make the same changes for es.js too.
Does spanish punctuation work the same way?

Otherwise the proposal is fine.

[mdneyazahmad]

@rushatgabhane I updated the proposal to include the respective changes in es.js too. I am not confident about the changes. Maybe someone else who knows Spanish language can help us move forward.

#6980 (comment)

[rushatgabhane]

letsChatText: 'Gracias Necesitamos

@mdneyazahmad pretty sure there's a period after Gracias.
Asked on slack for verifying Spanish punctuation.

[rushatgabhane]

🎀👀🎀 C+ reviewed
@mdneyazahmad's proposal is fine. Confirmed on slack

cc: @AndrewGable

[AndrewGable]

Looks good 👍

[rushatgabhane]

@mdneyazahmad small nudge, looks like you have a go ahead for a PR.

[rushatgabhane]

@mdneyazahmad please let us know when you can submit a PR. Thank you so much 😄

[mdneyazahmad]

@rushatgabhane My PR is ready, but I am unable to navigate to the screen and test. Could you please help me with test steps?

[rushatgabhane]

Good question. It's in workspace -> connect bank account manually. I tried setting it up using expensifail, but it asked for identity verification in step 4.

@mdneyazahmad what you could instead do is change the conditions in ReimbursementAccoutPage, and ValidationStep so that step 5 is rendered directly. I hope that helps.

[mdneyazahmad]

@rushatgabhane Thank you for your help. I will submit my PR soon.

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.31-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: misspelled copy in bank account validation step #7289

If no regressions arise, payment will be issued on 2022-01-27. 🎊

[JmillsExpensify]

@rushatgabhane Mind applying to to the linked Upwork job above so that we can submit payment? Thank you!

[rushatgabhane]

https://www.upwork.com/jobs/~0128c8d14a0f1522c5

@JmillsExpensify I've already applied 😄

[JmillsExpensify]

Haha sorry for my confusion. Settling up now.

[JmillsExpensify]

Separately, @mdneyazahmad I meant to ask you to make sure to apply as well. 😄 Ooops. Mind applying quick so we can process everything in one go?

[mdneyazahmad]

@JmillsExpensify applied

[JmillsExpensify]

I think we should officially be settled up on this issue. Thank you and don't hesitate to reach out if I'm missed something!