When bank account is pending a "Test transactions" heading displayed incorrectly

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Go through the VBA flow to trigger pending account

Expected Result:

"Test transactions" should display only for the page with the transactions CTA

Actual Result:

"Test transactions" displayed when user still has steps to complete verification
Potentially related to #6477

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.23-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @marcaaron
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640291627075700

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

@PrashantMangukiya Please wait for the Help Wanted label to be applied before proposing a solution. Thanks!

[alex-mechler]

This can be dne by a contributor! Adding the label

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

@laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[laurenreidexpensify]

Adding this to upwork now

[laurenreidexpensify]

https://www.upwork.com/jobs/~018c357627c8b5e886

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @deetergp (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[PrashantMangukiya]

Proposed Solution:

At present title is static so it shows same title all time. So we have to make title dynamic. We can set title (line 166) based on the isVerifying (line 161) variable, because isVerifying is controlling ui content that we concern. i.e. when isVerifying true it shows Let's Finish in Chat section, otherwise showing test transaction input form.

App/src/pages/ReimbursementAccount/ValidationStep.js

Lines 160 to 172 in bf65263

	const maxAttemptsReached = lodashGet(this.props, 'reimbursementAccount.maxAttemptsReached');
	const isVerifying = !maxAttemptsReached && state === BankAccount.STATE.VERIFYING;
	return (
	<View style={[styles.flex1, styles.justifyContentBetween]}>
	<HeaderWithCloseButton
	title={this.props.translate('workspace.common.testTransactions')}
	stepCounter={{step: 5, total: 5}}
	onCloseButtonPress={Navigation.dismissModal}
	onBackButtonPress={() => Navigation.goBack()}
	shouldShowBackButton
	shouldShowStepCounter={!isVerifying}
	/>

We have add/update code as shown below, It will make title dynamic as per need.

  // **** Add below code ***
  let titleText = this.props.translate('workspace.common.testTransactions');
  if (isVerifying) {
      titleText = this.props.translate('workspace.common.bankAccount');
  }

 <HeaderWithCloseButton
      title={titleText}      // *** Update this line 
      stepCounter={{step: 5, total: 5}}
      onCloseButtonPress={Navigation.dismissModal}
      onBackButtonPress={() => Navigation.goBack()}
      shouldShowBackButton
      shouldShowStepCounter={!isVerifying}
  />

Below is the screenshot once code updated:

[parasharrajat]

@PrashantMangukiya proposal looks good but I am not sure what should be the expected header or it is supposed to be hidden? cc: @marcaaron

[marcaaron]

I think definitely not hidden. @Expensify/marketing maybe can help.

[MelvinBot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[laurenreidexpensify]

@jliexpensify am OOO next week, back 11 Jan so reassigning

[jliexpensify]

Hello, taking over from Lauren here! Just wondering if you wanted me to hire anyone? Cheers! cc @marcaaron @parasharrajat

[parasharrajat]

I am still not sure what is decided for the header text. it seems we are still discussing but as we only need to change the text for it.

I think @PrashantMangukiya 's proposal is good #6900 (comment).

cc: @marcaaron
🎀 👀 🎀 C+ reviewed

[marcaaron]

Thanks, we're still waiting for copy so there's nothing to do for now.

[deetergp]

Are we still waiting on copy?

[parasharrajat]

Yeah.

[parasharrajat]

cc: @Expensify/marketing Could you please confirm the Header Text to be used for the screen?

[jamesdeanexpensify]

Do you just need review and approval of the two headers shown in this comment?

[parasharrajat]

No, we are looking to get the correct header name for the screen attached on the issue description.

[jamesdeanexpensify]

Maybe something like "Almost there..." ?

[parasharrajat]

cc: @marcaaron , He is involved in VBA.

[deetergp]

A penny for your thoughts, @marcaaron?

[marcaaron]

@jamesdeanexpensify suggestion to use "Almost there..." makes sense to me.

[parasharrajat]

Sounds good. I liked @PrashantMangukiya' proposal #6900 (comment).

cc: @deetergp

🎀 👀 🎀 C+ reviewed

[PrashantMangukiya]

There is another issue related to this and they implemented similar solution using isVerifying etc. (while we waiting for the grammar here). Here is the issue #7322 Now I am wandering what we have do in this issue. Someone from C+ or Expensify team please refer it and decide strategy what to do in this issue.

[parasharrajat]

Thanks for linking that @PrashantMangukiya .

Ok, This issue is fixed now via #7322. Let's just close it @jliexpensify

[jliexpensify]

Job closed, cheers Rajat!