iOS - Keyboard opens up after tapping invite the member

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app and log in with any account
2. Go to Setting
3. Tap on any Workspace you have in your account
4. Go to Manage Members
5. Tap Invite

Expected Result:

Keyboard should be dismissed after tap invite the member

Actual Result:

Keyboard isn’t dismissed after tap invite the member

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: v1.1.38.1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5447523_Image_from_iOS__8_.mp4

Screen_Recording_20220210-104815_New.Expensify.mp4

Note : Android and mweb keyboard does not open. So not sure which is correct behavior

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

view this job

[MelvinBot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bondydaa]

Hmm i'm not sure which is the proper one here either - it looks like we give focus to the input to invite someone so that's most likely why the keyboard is showing for iOS so I'd guess that might actually be the right behavior and that mobile web and android are broken.

I'll cross post this to our product channel to ask which is the expected behavior.

[bondydaa]

asked here https://expensify.slack.com/archives/C03U7DCU4/p1644518202678349 (internal slack channel)

[bondydaa]

waiting for others to chime in on the thead, i'm going to move this to a weekly for now while we wait for a consensus. I'm offline the next day anyways so i'll check back in next week and get this prioritized.

[bondydaa]

Alrighty after discussion / lack of push back in slack we decided that we should do the following:

1. On the Manage Members page
2. When Invite is clicked
3. On the next page: don't focus the input to enter an email and don't show the keyboard

So I agree that Android and mWeb then are correct and iOS seems to be wrong.

This should be fine for a contributor to work on / fix so adding the label.

[MelvinBot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Proposal

1. For this, we just need to remove the autofocus from the OptionSelector component.

   App/src/pages/workspace/WorkspaceInvitePage.js

   Line 259 in 0b7cc87

   <OptionsSelector

But this is a generic component and focus could be needed for other parts of the app, so we add another prop autofocus (default: true) to OptionSelector. When autofocus is false we skip this logic

App/src/components/OptionsSelector.js

Lines 101 to 107 in 0b7cc87

	componentDidMount() {
	if (this.props.shouldDelayFocus) {
	setTimeout(() => this.textInput.focus(), CONST.ANIMATED_TRANSITION);
	} else {
	this.textInput.focus();
	}
	}

.

then we set this prop to false here

App/src/pages/workspace/WorkspaceInvitePage.js

Line 259 in 0b7cc87

<OptionsSelector

[jboniface]

posted: view this job

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Triggered auto assignment to @chiragsalian (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

@chiragsalian unassigning myself because Rajat doesn't need a C+ review

[chiragsalian]

Proposal LGTM, feel free to create the PR @parasharrajat 🙂

[MelvinBot]

📣 @parasharrajat You have been assigned to this job by @chiragsalian!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jboniface]

looks like this is in progress

[parasharrajat]

Updating the PR with screenshots shortly. Its ready.

[jboniface]

merged but not deployed

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[jboniface]

on staging

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[jboniface]

@parasharrajat hey it looks like we both lost track of this (for me it was because the title never changed to let me know to pay it) -- I had to file a new job because the old one expired, can you apply here?

[parasharrajat]

@jboniface Yeah, lol. Applied now.

[jboniface]

offer sent

[parasharrajat]

Accepted it.

[jboniface]

paid!