Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autofocus on Workspace Invite member page #7803

Merged

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Feb 17, 2022

Details

Fixed Issues

$ #7675

Tests | QA Steps

  1. Launch the app and log in with any account
  2. Go to Setting
  3. Tap on any Workspace you have in your account
  4. Go to Manage Members
  5. Tap the Invite button.
  6. Confirm that no focus is applied to the search field automatically.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

image

iOS

image

Android

image

@shawnborton shawnborton added Design and removed Design labels Feb 17, 2022
@parasharrajat parasharrajat marked this pull request as ready for review February 24, 2022 22:44
@parasharrajat parasharrajat requested a review from a team as a code owner February 24, 2022 22:44
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team and chiragsalian February 24, 2022 22:44
@parasharrajat
Copy link
Member Author

Bump @chiragsalian

Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit daafe50 into Expensify:main Mar 1, 2022
@botify
Copy link

botify commented Mar 1, 2022

@chiragsalian looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 1, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor

@Expensify/applauseleads can we please add this case to TF?

@isagoico
Copy link

isagoico commented Mar 2, 2022

@roryabraham Do you mean TestRail? And sure we can add the steps to the regression. Are there any other area that needs to be tested for auto focus?

@roryabraham
Copy link
Contributor

Yes, I meant TestRail, not TestFlight.

Are there any other area that needs to be tested for auto focus?

Not that I know of. I just want to make sure we get into the habit of testing edge cases that we fix so that they don't come back.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.42-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the managed-autofocus-OptionSelector branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants