iOS - Workspace - Unable to see searched user, missing "Done" button in keyboard

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app and log in with expensifail account
2. Tap on Setting
3. Tap on Any Workspace
4. Go to Manage users
5. Tap Invite
6. Start type any user you are want to add

Expected Result:

Able to see searched user, "Done" button in keyboard is appeared.

Actual Result:

Unable to see searched user, missing "Done" button in keyboard

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.42.4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+0707abb@applause.expensifail.com / Feya87Katya
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Gonals]

I don't have the bandwidth to take this right now. I think it requires some extra investigation to see when it happens/if it can be consistently reproduced, byt it can probably be fixed by an external contributor.

[MelvinBot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[adelekennedy]

Internal
External

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[MelvinBot]

Triggered auto assignment to @Julesssss (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[thesahindia]

Proposal

1. Need to pass returnKeyType="done" to the TextInput
   

   App/src/components/OptionsSelector.js

   Lines 220 to 225 in 3696074

   	<TextInput
   	ref={el => this.textInput = el}
   	value={this.props.value}
   	onChangeText={(text) => {
   	if (this.props.shouldFocusOnSelectRow) {
   	this.textInput.setNativeProps({selection: null});

Able to see searched user

2. I had reported this but it was decided that we leave it as it is, if we want to change this we can do this by removing KeyboardAvoidingView because of this the button and text area won't get in the way when the keyboard is open.

   App/src/pages/workspace/WorkspaceInvitePage.js

   Lines 249 to 251 in 3696074

   	<ScreenWrapper>
   	{({didScreenTransitionEnd}) => (
   	<KeyboardAvoidingView>

Edit:- Removing the KeyboardAvoidingView caused problems when tried to add text in the personal message text area

[Santhosh-Sellavel]

@thesahindia Can you point us to thread where you reported this?

[thesahindia]

@thesahindia Can you point us to thread where you reported this?

Yeah sure, It was decided to fix a different issue because it was minor and only affects small screen devices #6594 (comment)
I don't think we can fix this without changing the design.

[Santhosh-Sellavel]

Thanks! @thesahindia

@Julesssss Can we loop in the design team before getting the proposals reviewed?

[melvin-bot]

Triggered auto assignment to @megankelso (Design), see these Stack Overflow questions for more details.

[Julesssss]

@Santhosh-Sellavel, sure. I'm OOO but will back to check on this next week.

[Santhosh-Sellavel]

@Julesssss bumb!

[Julesssss]

Okay, so on re-reading this it seems like we are just proposing a switch of the keyboard type? Because the 2nd issue caused other issues elsewhere?

If so, I'm not sure that we need to make the change. As many other input fields are not using the 'done' keyboard. Does anyone dissagree with closing this?

[Santhosh-Sellavel]

@Julesssss
The second was intentionally left out unaddressed as per #6594 (comment)

It was now to be reported again by Applause if the design team agrees to leave this as it is let close this one.

[megankelso]

I agree with Jules comment, I don't think we need to switch the keyboards here.

[megankelso]

will go ahead and close, re-open if needed!