Deploy Checklist: New Expensify 2022-04-08

[roryabraham]

Release Version: 1.1.54-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• 7535 refactor picker compatible form #7807

  • QA
  • Accessibility

• Fix - Uploading Mp4 Videos Removes 'Attachment' Tag  #8438

  • QA
  • Accessibility

• Display list of unique members and filter phone logins #8496

  • QA
  • Accessibility

• fix console error when up arrow is pressed in emoji picker #8510

  • QA
  • Accessibility

• [No QA] Add NewDot deployer responsibilities #8518

  • QA
  • Accessibility

• [refactor] Replace all occurence of 'data-expensify-source' with a const  #8539

  • QA
  • Accessibility

• [NoQA] Fix the new contributor message #8542

  • QA
  • Accessibility

Deploy Blockers:

• Profile - Timezone isn't updated automatically after selected "Set my timezone automatically", works after refresh #8570

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.54-0 🚀

[mvtglobally]

Regression completed
Blocker - #8570

Issues logged
#8497
#8501
#8519
#8520
#8534
#8545
#8572
#8507
#8537
#8541
#8573
#8574

[Julesssss]

The single deploy blocker is being discussed here.

[Julesssss]

Marking the deploy-blocker as resolved, now that the fix is merged (and imminently going to be cherry-picked)

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.54-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.54-1 has been deployed to staging 🎉

[mvtglobally]

@Julesssss It doesn't look like the fix has been deployed yet on all platforms, can you confirm we are good to check or wait? #8599

[Julesssss]

Hey @mvtglobally. Ah, thanks for mentioning that, it looks like we have an issue with the cherry-pick. I'll ping you once it's ready, but this will likely be tomorrow now.

[Julesssss]

Hey @mvtglobally, I believe this is now deployed to staging on all platforms.

[Stutikuls]

Checked all PRs and creating accessibility issues for all PRs where accessibility issue was found.
The non-applicable PRs are - #7807, #8518, #8542
Logged Issues- #8478 , #8479, #8480 , #8430, #8463, #8616

[mvtglobally]

@Julesssss CP is Pass. We are good to deploy it seems

[Julesssss]

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[Julesssss]

Ah, new checks.

So unfortunately it looks like we're seeing a new exception with Android version 1.1.54. Same exception is occuring on iOS too.

It's non-fatal, so the user shouldn't notice this. But just to be safe I'm going to bring this up on the PR which I believe introduced the issue.

[Julesssss]

Confusingly, none of the above PRs seem related to the new issue 😕

My best guess is this PR from a couple of versions ago, which refactored the function which is listed as the origin of this new exception. It looks like we're attempting to call these functions before they are defined, but I can't point to a specific recent change.

[Julesssss]

With the occurrences spiking on a single day and no specific code changes which directly modified the problematic area, I think it's okay to continue with the release and I'll submit a quick PR to protect from this crash.

[Julesssss]

Okay, second attempt to deploy

[Julesssss]