Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile - Timezone isn't updated automatically after selected "Set my timezone automatically", works after refresh #8570

Closed
kbecciv opened this issue Apr 8, 2022 · 9 comments
Assignees
Labels
Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Apr 8, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Log in with any account
  3. Go to Setting - Profile
  4. Unselect "Set my timezone automatically" and use any time zone
  5. Select Save button
  6. Select "Set my timezone automatically" and Save

Expected Result:

Timezone is updated after selected "Set my timezone automatically" without any refresh

Actual Result:

Timezone isn't updated after selected "Set my timezone automatically", works after refresh

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.54.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): n/a

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.189.mp4
Bug5525607_timezone_0804.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 8, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Apr 8, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Apr 8, 2022

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@chiragsalian
Copy link
Contributor

Hmm okay i see reproduce the issue on dev and staging.

From a quick bisect and i found the issue was from this commit - 01fa795, which is in this GH issue - #7807. I'm not exactly sure how its causing the problem just yet. Investigating.

@chiragsalian chiragsalian added the Reviewing Has a PR in review label Apr 11, 2022
@melvin-bot melvin-bot bot closed this as completed Apr 11, 2022
@Julesssss
Copy link
Contributor

Resolved. Thanks!

@Julesssss Julesssss reopened this Apr 11, 2022
@Julesssss
Copy link
Contributor

@kbecciv please retest on staging, as we just merged and cherry-picked a fix 🤞

@kbecciv
Copy link
Author

kbecciv commented Apr 11, 2022

@Julesssss Thank you, we will retest shortly.

@chiragsalian
Copy link
Contributor

I lost track here. So whats the latest on this. Was this retested on version 1.1.54-1?

@Julesssss
Copy link
Contributor

@chiragsalian yep, mentioned here

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Apr 13, 2022
@chiragsalian
Copy link
Contributor

Closing issue as its resolved on staging and doesn't occur on production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants