Deploy Checklist: New Expensify 2022-07-07

[roryabraham]

Release Version: 1.1.82-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix: scroll to right position on text insertion #9062

  • QA
  • Accessibility

• Replace Report_AddComment with AddComment (Part 2) #9350

  • QA
  • Accessibility

• Fix crashes when personal details are not available #9385

  • QA
  • Accessibility

• Make CheckboxWithLabel work with Form if shouldSaveDraft=false #9476

  • QA
  • Accessibility

• Refactor the API for saving the report notification preferences #9501

  • QA
  • Accessibility

• [No QA] add new help site project #9519

  • QA
  • Accessibility

• Fix workspace members page blinking #9567

  • QA
  • Accessibility

• Start using new new RequestCall Onyx-optimized API command instead of Inbox_CallUser #9573

  • QA
  • Accessibility

• Set light themeVariant to DatePicker component iOS #9599

  • QA
  • Accessibility

• added blurOnSubmit to OptionsSelector for prenting empty search #9601

  • QA
  • Accessibility

• Use new API command LogOut #9602 - @Beamanator @Julesssss

  • QA
  • Accessibility

• Double max participant message fix #9610

  • QA
  • Accessibility

• [No QA] Run lint and test jobs in parallel #9611

  • QA
  • Accessibility

• [No QA] Make preDeploy continue if lint and test succeed #9612

  • QA
  • Accessibility

• [No QA] Setup composite run step actions #9618

  • QA
  • Accessibility

• [No QA] Create composite action to set up git for OSBotify #9619

  • QA
  • Accessibility

• Prevent blocking Android UI when getting the image size #9621

  • QA
  • Accessibility

• Scroll to the top when new options are selected on multiple-selection screens #9626

  • QA
  • Accessibility

• Refactor NVP.Get in App #9627

  • QA
  • Accessibility

• [No QA] Add documentation about error onyx best practice under API.md #9629

  • QA
  • Accessibility

• Allow free policies to have their default rooms be shown #9632

  • QA
  • Accessibility

• [No QA] Use uuid to generate branch name in updateProtectedBranch #9639

  • QA
  • Accessibility

• [No QA] Wait for checks to complete before giving up due to mergeable_state blocked #9643

  • QA
  • Accessibility

• Add FullPageNotFoundView #9649 - @arosiclair @Justicea83

  • QA
  • Accessibility

• [Refactor] PreferredLocale_Update #9650

  • QA
  • Accessibility

• [No QA] Pass secret as input to compound action #9651

  • QA
  • Accessibility

• [No QA] Migrate updateProtectedBranch from workflow to composite action #9654

  • QA
  • Accessibility

• Create a FormAlertWrapper that handles more complex components #9665

  • QA
  • Accessibility

• Make CMD+Enter work for single-selection pages #9672

  • QA
  • Accessibility

• Fix off-by-one error in scrollToIndex #9674

  • QA
  • Accessibility

• Fix ArrowKeyFocusManager for lists with only two options #9682

  • QA
  • Accessibility

• [No QA] Deploy help site to GitHub Pages #9689

  • QA
  • Accessibility

• Revert "Fix off-by-one error in scrollToIndex" #9690

  • QA
  • Accessibility

• [No QA] Centralize all our documents in the docs folder #9694

  • QA
  • Accessibility

• [No QA] Remove myself as codeowner for certain files #9711

  • QA
  • Accessibility

• Fix OptionsSelector crash #9714

  • QA
  • Accessibility

• Remove fetchFreePlanVerifiedBankAccount from app init #9715

  • QA
  • Accessibility

• [No QA] Alert failed deployHelpSite workflow in slack #9721

  • QA
  • Accessibility

• [No QA] Use commit hash from latest release tag #9722

  • QA
  • Accessibility

• [No QA] Fix updateProtectedBranch composite action #9729

  • QA
  • Accessibility

• [Snyk] Upgrade electron-log from 4.4.6 to 4.4.7 #9732

  • QA
  • Accessibility

• [Prod QA] Fix CSP for statement frames on Desktop #9738 - @parasharrajat @MonilBhavsar

  • QA
  • Accessibility

• [No QA] Deploy help site with GH Pages built-in Jekyll #9748

  • QA
  • Accessibility

• [Snyk] Upgrade @storybook/addon-essentials from 6.4.12 to 6.5.9 #9750

  • QA
  • Accessibility

• [No QA] Update podfile #9757

  • QA
  • Accessibility

• [No QA] Setup modular sass config and add color file to help site #9760

  • QA
  • Accessibility

• [No QA] Fixing the link to code of conduct #9763

  • QA
  • Accessibility

• [No QA] Fix NewDot deploys #9771

  • QA
  • Accessibility

• [No QA] Continue merge without requiring editor #9775

  • QA
  • Accessibility

• [No QA] Fix lint and tests on main #9776

  • QA
  • Accessibility

• [No QA] Fix Storybook to fix staging web deploys #9783

  • QA
  • Accessibility

• [No QA] Make temporary copies of moved javascript actions #9784

  • QA
  • Accessibility

• Revert "[Prod QA] Fix CSP for statement frames on Desktop" #9785

  • QA
  • Accessibility

Internal QA:

• [Prod QA] Fix CSP for statement frames on Desktop #9738 - @parasharrajat @MonilBhavsar
• Add FullPageNotFoundView #9649 - @arosiclair @Justicea83
• Use new API command LogOut #9602 - @Beamanator

Deploy Blockers:

• CORS errors on the latest staging version of the Desktop app #9786
• Payment - Add payment method button is misaligned  #9838

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[roryabraham]

Please keep this unlocked for a bit

[mvtglobally]

@roryabraham tag us when it's good to lock it. It's already late, we will start regression in the morning

[roryabraham]

@Expensify/applauseleads You can lock this whenever you're ready 🙇

[roryabraham]

Verified that #9786 was resolved by #9785, checking both off. I'll also check off #9738 for now because it's been reverted.

[roryabraham]

Checked off #9732 because it's not a blocker, but it appears electron-log maybe hasn't been working since March? That's the most recent log I'm seeing in ~/Library/Logs/new.expensify/main.log

[roryabraham]

Also there's a bunch of PRs that were already deployed to production included in this checklist. Going to check them off and hope that it's a one-off error resulting from the deploy woes earlier today / me having to manually create this checklist.

[roryabraham]

Checking off #9750 because it was fixed by #9783. You can verify that it's working on staging by going to https://staging.new.expensify.com/docs/index.html

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.82-5 🚀

[mvtglobally]

Regression is completed. Will share summary in a bit

[mvtglobally]

@AndrewGable

PR #9385 one tester was able to repro #8641 (comment). Since its existing issue, checking off.
PR #9501 is failing #9805. Repro in PROD checking off
PR #9627 & #9650 is failing #9802. Potential blocker. Pls double check
PR #9649 - @arosiclair @Justicea83 Can you check this off?
PR #9665 is pending clarification #9665 (comment)

Issues logged
#9742
#9741
#9747
#9766
#9802
#9805
#9807
#9808
#9809
#9816
#9817
#9827

[mvtglobally]

@AndrewGable just checking if we need to do anything to try and push this checklist today

[AndrewGable]

No, I am working on getting all the internal QA items checked off

[mvtglobally]

checking off #9665 https://expensify.slack.com/archives/C9YU7BX5M/p1657649041410549

[AndrewGable]

@mvtglobally - Were you able to test #9627 ?

[mvtglobally]

@AndrewGable Yes, The only issue is #9802. I think we can check it off as thats expected

[AndrewGable]

[AndrewGable]

Deploy did not work, we are looking into it

[roryabraham]

Closing this again

[roryabraham]

New checklist is here