Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-09-20] [HOLD for payment 2022-08-01] [$250] Android - Keyboard doesn't always open on search (reported by @jayeshmangwani) #9827

Closed
kbecciv opened this issue Jul 11, 2022 · 46 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jul 11, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app
  2. Press search from the header
  3. Search input is active but the keyboard is hidden
    Note: try 3-4 times issue is inconsistent

Expected Result:

Keyboard should always open

Actual Result:

Sometimes does not open

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.82.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

search-keyboard.mp4

Expensify/Expensify Issue URL:

Issue reported by: @jayeshmangwani

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1656618123670899

View all open jobs on GitHub

@kbecciv kbecciv added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2022

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels Jul 11, 2022
@laurenreidexpensify laurenreidexpensify removed their assignment Jul 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2022

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sketchydroide
Copy link
Contributor

this seems to not be a problem in iOS, maybe just Android?
Either way I feel this can be an external

@sketchydroide sketchydroide added the External Added to denote the issue can be worked on by a contributor label Jul 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2022

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added the Overdue label Jul 13, 2022
@kevinksullivan kevinksullivan changed the title Android - Search page keyboard is not open sometimes @jayeshmangwani Android - Keyboard is doesn't always open on search (reported by @jayeshmangwani) Jul 13, 2022
@kevinksullivan kevinksullivan changed the title Android - Keyboard is doesn't always open on search (reported by @jayeshmangwani) Android - Keyboard doesn't always open on search (reported by @jayeshmangwani) Jul 13, 2022
@kevinksullivan
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Jul 13, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2022

Current assignee @sketchydroide is eligible for the Exported assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title Android - Keyboard doesn't always open on search (reported by @jayeshmangwani) [$250] Android - Keyboard doesn't always open on search (reported by @jayeshmangwani) Jul 13, 2022
@rushatgabhane
Copy link
Member

rushatgabhane commented Jul 14, 2022

Also applicable to New group, and New chat page. A proposal should fix all three pages

@jeet-dhandha
Copy link
Contributor

jeet-dhandha commented Jul 14, 2022

Proposal

<OptionsSelector

Solution:

<OptionsSelector
    shouldDelayFocus={true}     // add this line
    sections={sections}
    value={this.state.searchValue}
    onSelectRow={this.selectReport}

Tried using the upper prop works fine now.

@rushatgabhane @kevinksullivan @sketchydroide
Please check this. Also I haven't applied for job yet but still if this works then will apply it.

@rushatgabhane
Copy link
Member

rushatgabhane commented Jul 14, 2022

🎀 👀 🎀 C+ reviewed
@jeet-dhandha thanks for your proposal, it looks good. Btw, you don't need to pass true explicitly. Shorthand is fine shouldDelayFocus

cc: @sketchbook

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2022
@kevinksullivan
Copy link
Contributor

@rushatgabhane can you let us know if this caused a regression?

@melvin-bot melvin-bot bot removed the Overdue label Aug 24, 2022
@kevinksullivan kevinksullivan removed their assignment Aug 24, 2022
@kevinksullivan kevinksullivan added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Aug 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 24, 2022
@kevinksullivan kevinksullivan removed their assignment Aug 24, 2022
@kevinksullivan kevinksullivan added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Aug 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@kevinksullivan
Copy link
Contributor

Reassigning as I'm OOO for a bit. Thanks @michaelhaxhiu !

@rushatgabhane
Copy link
Member

rushatgabhane commented Aug 24, 2022

can you let us know if this caused a regression?

I don't think so, I can't repro the regression - #10414 (comment)

@michaelhaxhiu
Copy link
Contributor

This seems ready for payment! I'm going to work on that now.

@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2022
@michaelhaxhiu
Copy link
Contributor

michaelhaxhiu commented Aug 29, 2022

Done.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.99-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-09-20. 🎊

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2022-08-01] [$250] Android - Keyboard doesn't always open on search (reported by @jayeshmangwani) [HOLD for payment 2022-09-20] [HOLD for payment 2022-08-01] [$250] Android - Keyboard doesn't always open on search (reported by @jayeshmangwani) Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants