-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update The Free Plan article #12697
update The Free Plan article #12697
Conversation
@parasharrajat @arosiclair One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Removing C+ review since this is only a text change for the Expensify Help site |
|
Reviewer Checklist
Screenshots/VideosDesktopN/A iOSN/A AndroidN/A |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @arosiclair in version: 1.2.28-0 🚀
|
🚀 Deployed to staging by @arosiclair in version: 1.2.28-0 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.2.28-2 🚀
|
cc @RachCHopkins
Details
Update content for The Free Plan article
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/242173
Tests
Pre-requisites (only in dev):
In order to run the site locally you would need ruby and bundler installed in your machine, more info here.
Then just execute the following commands in your command-line:
Steps:
QA Steps
Same steps as
Test
section (test only in production). Note that this is a helpsite PR, so it's deployed straight to production upon merge. We can treat this as production QA and it should not become a deploy blocker, even if there are problems.PR Author Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots
Web
Screen.Recording.2022-11-12.at.9.18.43.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
N/A
iOS
N/A
Android
N/A