-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix form terminology #18160
Fix form terminology #18160
Conversation
@arosiclair @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@getusha The PR is missing Test and QA steps. |
@mananjadhav sorry I missed that, i've updated the PR description with the test steps. |
Reviewer Checklist
Screenshots/Videos |
Thanks for the quick PR @getusha. @arosiclair All yours, and ES copies look good, but do let me know if any changes required in spanish translations. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.9-12 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀
|
Details
Fixed Issues
$ #17539
PROPOSAL: #17539 (comment)
Tests
Please select
instead ofPlease enter
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-04-28.at.6.56.02.PM.mov
Mobile Web - Chrome
Screen.Recording.2023-04-28.at.8.28.01.PM.mov
Mobile Web - Safari
Screen.Recording.2023-04-28.at.8.07.58.PM.mov
Desktop
Screen.Recording.2023-04-28.at.7.07.22.PM.mov
iOS
Screen.Recording.2023-04-28.at.11.34.22.PM.mov
Android
Screen.Recording.2023-04-28.at.9.31.25.PM.mov