-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled distance rate is present in the rate list in confirmation p #42330
Conversation
bf6fb31
to
f11e7eb
Compare
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@cretadn22 Regarding the PR description tests, I'd be more specific so the QA team has a better understanding of the changes and what to test. Note: Here's the pastebin so you can easily copy & paste the below steps in your PR's description. Tip Test 1Precondition: User does NOT have betas enabled, hence no Rate field will be displayed in Distance confirmation page.
Test 2Precondition: User does has betas enabled, hence the Rate field will be displayed in Distance confirmation page.
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb Chromeandroid-mweb.moviOS: NativeiOS: mWeb Safariios-mweb.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
@cretadn22 I will ✅ Approve once the 2 comments (#42330 (comment) and #42330 (comment)) are addressed. Note: Please don't force-push anymore as this goes against the guidelines, see Submit your pull request for final review:
|
Co-authored-by: Kevin Brian Bader <56457735+ikevin127@users.noreply.github.com>
@ikevin127 Thanks for your comments, It will greatly assist me in future PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cretadn22 Sure, thanks for promptly updating the PR!
Just a note regarding the PR description tests -> it's missing the picture from Test 1 under step (8.):
<img width="360" alt="Screenshot 2024-05-29 at 14 10 59" src="https://github.com/Expensify/App/assets/56457735/fad564df-1bf3-4998-ac65-b402f2d1da69">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good, thanks! I'm requesting changes for a couple small clean up items.
@neil-marcellini Your comments make sense, I made an update to address your suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, looking really close. Two more small things @cretadn22
@neil-marcellini I addressed your comment and removed the description of getMileageRates function |
@neil-marcellini Hi, Wdyt about my update? |
Hi, sorry I lost track of this. I plan to review today or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@cretadn22 @ikevin127 @neil-marcellini this PR most probably is causing this crash. Can anyone please take a look. Thanks! |
A small feedback here - The PR title can be more descriptive so one can find the PR from the list of deployed PR's |
@cretadn22 Can you please edit the PR title here on tgithub to match the issue's title, like: Also it's possible that this PR caused these regressions: #43197 and #43171. Can you confirm if those two were caused by this PR's code changes ? You can do this by changing the code back to what it was before (locally) and checking if the issues are still occuring. |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀
|
Details
Defaulting distance rate to the first enabled when the Rate field is not shown (users with betas disabled).
Not displaying the disabled distance rates in the Rate field list (users with betas enabled).
Fixed Issues
$ #42284
PROPOSAL: #42284 (comment)
Tests
Offline tests
QA Steps
Test 1
Precondition: User does NOT have betas enabled, hence no Rate field will be displayed in Distance confirmation page.
Test 2
Precondition: User does has betas enabled, hence the Rate field will be displayed in Distance confirmation page.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-05-29.at.23.28.03.mp4
Android: mWeb Chrome
Screen.Recording.2024-05-29.at.23.23.04.mp4
iOS: Native
Screen.Recording.2024-05-29.at.23.27.08.mp4
iOS: mWeb Safari
Screen.Recording.2024-05-29.at.23.48.08.mp4
MacOS: Chrome / Safari
CDLA-1.mp4
MacOS: Desktop
Screen.Recording.2024-05-29.at.23.22.29.mp4