Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we get state/status from the right variable name when we get chat report name #4239

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Make sure we get state/status from the right variable name when we get chat report name #4239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@ function getChatReportName(fullReport, chatType) {
if (isDefaultRoom({chatType})) {
return `#${fullReport.reportName}${(isArchivedRoom({
chatType,
stateNum: fullReport.stateNum,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, are we still passing stateNum from the back end, and if so is it being used anywhere in the front end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not. It comes from the back-end as state/status, but elsewhere in E.chat it's stateNum/statusNum

statusNum: fullReport.reportStatus,
stateNum: fullReport.state,
statusNum: fullReport.status,
})
? ` (${translateLocal('common.deleted')})`
: '')}`;
Expand Down