Make sure we get state/status from the right variable name when we get chat report name #4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t chat report name
|
|
joelbettner
reviewed
Jul 26, 2021
| @@ -140,8 +140,8 @@ function getChatReportName(fullReport, chatType) { | |||
| if (isDefaultRoom({chatType})) { | |||
| return `#${fullReport.reportName}${(isArchivedRoom({ | |||
| chatType, | |||
| stateNum: fullReport.stateNum, | |||
There was a problem hiding this comment.
Out of curiosity, are we still passing stateNum from the back end, and if so is it being used anywhere in the front end?
There was a problem hiding this comment.
We're not. It comes from the back-end as state/status, but elsewhere in E.chat it's stateNum/statusNum
TomatoToaster
approved these changes
Jul 27, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
(cherry picked from commit c00186d)
This was referenced Jul 27, 2021
|
🚀 Cherry-picked to staging in version: 1.0.80-2🚀
|
71 tasks
|
🚀 Cherry-picked to production in version: 1.0.80-2🚀
|
|
🚀 Deployed to staging in version: 1.0.80-3🚀
|
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
This was referenced Jul 30, 2021
This was referenced Aug 11, 2021
This was referenced Aug 25, 2021
This was referenced Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomatoToaster please review
Details
I messed up here and was pulling the
state/statusfromstateNum/statusNumrather thanstate/statusFixed Issues
$ #4023
Tests/QA
See: #4023 (comment)
Made sure
(deleted)was showing in the report name: