Prevent large attachment #4269
Merged
Prevent large attachment #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went with this style because 3 out of 3 non-tech people agreed with it. Current style
Alternative style
|
|
I agree, I like the current style you have. |
deetergp
requested changes
Jul 28, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Jul 29, 2021
|
🚀 Deployed to staging in version: 1.0.81-5🚀
|
|
Issue found for this PR #4356 |
2 tasks
|
🚀 Deployed to production in version: 1.0.82-7🚀
|
|
👋 blast from the past! Heads up as part of the new BugZero checklist. This PR caused a regression whereby the max file size was set to 50 MB, but the server only allows for 25 MB. One to look out for in the future. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Acceptable API attachment size: Less than 50 MB (52428800 bytes). Source
ConfirmModalis used to display a message when a larger file is uploaded.The following language is added.
English
Attachment too large
Attachment size is larger than 50 MB limit.
Spanish (Source & verification)
Archivo adjunto demasiado grande
El archivo adjunto supera el límite de 50 MB.
Fixed Issues
$ #3926
Tests / QA
fsutil file createnew test50 52428800mkfile -n test50 50m+in chat, then press Add Attachment.Tested On
Screenshots
Web
English
Spanish
Mobile Web
Desktop
iOS
Android