Deploy Checklist: Expensify.cash 2021-07-30

[OSBotify]

Release Version: 1.0.82-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Update Enable Payments terms page with updated terms #3879
• Deselect attendees when splitting bill #3881
• Add offline message to IOU and Split bill and allow currency selection while offline #4019
• [No QA] Add test for matching Translations keys #4090
• Update copy to refer to new URL #4091
• [CP Staging] Remove duplicate form fields #4117
• 🍒 Cherry pick PR #4117 to staging 🍒 #4125
• fix: paste and Ctrl+z #4131
• Modify line height so text does not get cut off in LHN #4143
• 🍒 Cherry pick PR #4131 to staging 🍒 #4149
• 🍒 Cherry pick PR #4143 to staging 🍒 #4152
• Adjust outline for focused elments #4170
• [IS-3599] Fixed crash issue when editing a message #4172
• 🍒 Cherry pick PR #4019 to staging 🍒 #4193
• Context-menu repositioned #4194
• Update version to 1.0.79-5 on staging #4197
• Update version to 1.0.79-6 on staging #4202
• Update version to 1.0.80-0 on staging #4204
• Added Balance badge to the Settings page #4220
• [InternalQA] Update Workspace button text during pending account validation #4237
• Make sure we get state/status from the right variable name when we get chat report name #4239
• Revert add payment button changes #4242
• Web - Settings - Dropdown symbol overlaps with text in the box #4243
• 🍒 Cherry pick PR #4243 to staging 🍒 #4245
• Show verification modal instead of redirecting to concierge #4246
• 🍒 Cherry pick PR #4239 to staging 🍒 #4249
• Perf: remove Onyx usage from withLocalize #4253
• Make sure users are signed in when clicking on managed cards #4255
• [No QA] Implement Why Did You Render #4260
• Fix bolded text for Existing Owners Error #4261
• Prevent large attachment #4269
• Disable the submit button if required form fields are not filled out #4272
• Use proper width for Cancel/Decline Button Text #4275
• Update version to 1.0.80-3 on staging #4278
• Update version to 1.0.81-0 on staging #4282
• fix styling for report typing and timezone indicators #4285
• Fix staging due to undefined Onyx key #4286
• 🍒 Cherry pick PR #4286 to staging 🍒 #4289
• [No QA] Setup Flipper plugins when on native & dev #4290
• Fix: urls for user details #4291
• Update Standard.md #4294
• chore(bumped-ecommon-ver): Updated expensify-common version #4295
• [No QA] Fix crash #4297
• Allow editing of Workspace names #4298
• Fix broken list components on staging #4300
• [No QA] Update company address label text #4301
• 🍒 Cherry pick PR #4300 to staging 🍒 #4306
• Fix rendering of timezone info inside chats when the selected language is Spanish #4309
• Directly create a workspace and add the Edit Workspace page #4310
• Reduce debounce time to 75ms when filtering search. #4311
• Update Onyx version to improve handling of defaultKeyStates #4312
• Different throw for Missing partnerUserSecret #4313
• Use activeComponentBG for Workspace menu items #4314
• Show time and date in the preferred locale #4316
• [No QA] Fix Flipper for Android #4317
• Send emailList as string when removing from workspace #4318
• Copy change for personal address to avoid drop addresses #4320
• Patch for PR #4190  #4322
• 🍒 Cherry pick PR #4322 to staging 🍒 #4327
• Update version to 1.0.81-5 on staging #4332
• Update version to 1.0.81-6 on staging #4335
• Update getPullRequestsMergedBetween to run pre-set string command #4336
• Update XCode to fix iOS deploy #4339
• Update version to 1.0.81-7 on staging #4341
• Update version to 1.0.81-8 on staging #4344
• Update version to 1.0.82-0 on staging #4347
• Perf: Add context factory helper to speed up chat switching #4348
• expensify-common hash update #4349
• Fix white screen when trying to navigate empty search results #4351
• Changes to how validation displays in UI #4354
• Fix User is able to upload a file larger than 50mb #4358
• Fix timerow should update on Language changes. #4360
• Update E-common #4363
• Fix: Selecting a language does not update in real time #4366
• 🍒 Cherry pick PR #4358 to staging 🍒 #4369
• [No QA] Switch warnCPLabel trigger from pull_request to pull_request_target #4370
• [No QA] [Performance] Approximate the ideal number of reports to render on first render #4371
• IOU Error Handling, navigated back to Amount Page on error #4378
• Navigation.isActiveRoute function updated to handle currentRoute logic #4382
• Meta Tweaks for #4275 #4383
• handle navigation when reportID isn't valid #4387
• [NO QA] Clarify risk of submitting early proposals #4391
• Treat Default Chat Rooms like Multiple Participant Rooms when it comes to their OptionRow->login property #4393
• Fixes styling for hidden element again #4394
• Fix misaligned text on Workspace Card Page #4396
• Fix: Infinite loader on login #4397
• Fix: inline messages #4399
• [No QA] Catch http errors that don't trigger .then() #4400
• Don't show loading state in workspace setup button #4401
• don't show localTime for Chronos #4403
• #2430 remove app.relaunch on desktop update #4406
• Fix Password Forms Header Title #4410
• PR changes requested #4412
• Attempt at fixing race #4416
• Fix: incorrect prop name passed for locale #4419
• Race fix attempt 2 #4436

Deploy Blockers:

• Infinite Loading spinner on Login screen #4221
• Desktop - Chat - Timezone information not updated after language change #4352
• User is able to upload a file larger than 50mb  #4356
• White screen on iOS login #4388

cc @Expensify/applauseleads

[isagoico]

Starting QA 🚀

[isagoico]

@roryabraham @AndrewGable There was a problem with iOS deploy. We are currently holding all iOS tests since 1.0.81-5 failed to deploy there.

[isagoico]

Regression is finished (For Web, Android and desktop):
Issues found:

1. Desktop - Chat - Timezone information not updated after language change #4352 - Failing Fix rendering of timezone info inside chats when the selected language is Spanish #4309 for Desktop
2. User is able to upload a file larger than 50mb  #4356 - Failing Prevent large attachment #4269 For Android

Checking these PRs off since they were a pass and they required testing only on Web or mWeb:

• Disable the submit button if required form fields are not filled out #4272
• Adjust outline for focused elments #4170
• Revert add payment button changes #4242
• Make sure users are signed in when clicking on managed cards #4255
• Reduce debounce time to 75ms when filtering search. #4311
• Copy change for personal address to avoid drop addresses #4320

Unchecked PRs have not been tested in iOS because of the failing build. Once the build is out we will test and check those that were pass and run the regression TCs.

[roryabraham]

Just a quick update @isagoico we are still working on fixing iOS deploys. We're currently CPing a PR we hope should resolve the issue.

[isagoico]

Great! We'll be on standby until that's CPd to start all iOS tests.

[roryabraham]

Yay, looks like the last iOS deploy was a success! https://github.com/Expensify/App/actions/runs/1091288292 So feel free to begin QA whenever you're ready.

[roryabraham]

Separately, I noticed that when we manually CP a pull request, the checklist is not updated to include the PR. Created an issue here.

[isagoico]

Checking off these PRs that were mistakenly added to the list (CP issue):

• Update copy to refer to new URL #4091
• Show verification modal instead of redirecting to concierge #4246
• Allow editing of Workspace names #4298
• Use activeComponentBG for Workspace menu items #4314
• Fix white screen when trying to navigate empty search results #4351
• Fix timerow should update on Language changes. #4360
• Update E-common #4363

[parasharrajat]

@isagoico I think #4363 needs to be tested.

[isagoico]

@parasharrajat PR is not in staging yet, it was added to the checklist because of an existing bug with Cherry Picks. It will be tested in next deploy checklist. CC @roryabraham (just in case I'm mistaken and PR is indeed in staging)

[parasharrajat]

Ok. Yeah. Thanks.

[isagoico]

iOS tests are done:

1. Desktop - Chat - Timezone information not updated after language change #4352 is still reproducible and failing Perf: remove Onyx usage from withLocalize #4253 and Fix rendering of timezone info inside chats when the selected language is Spanish #4309
2. User is able to upload a file larger than 50mb  #4356 was a pass in both Android and iOS

Thanks!

[isagoico]

Checking off a bunch more:

1. Deselect attendees when splitting bill #3881
2. [InternalQA] Update Workspace button text during pending account validation #4237
3. expensify-common hash update #4349
4. [No QA] Switch warnCPLabel trigger from pull_request to pull_request_target #4370
5. [No QA] [Performance] Approximate the ideal number of reports to render on first render #4371

[isagoico]

Checking off #4366 and #4309 since retest was a pass 🎉

Edit: Also #4253 was a pass

[Jag96]

Checking off a bunch of PRs that got added b/c of the CP bug, #4416 is the PR that was CPd in order to fix #4388, so that one can be retested.

[Jag96]

I've also CPd #4397 to staging, so this deploy blocker can be tested again!

[AndrewGable]

Tested both deploy blockers, both passed!

[Jag96]

[botify]

Be sure to fill out the Contact List!

[Jag96]

[botify]

Be sure to fill out the Contact List!

[AndrewGable]

This @botify comment here #4333 (comment) is breaking the deploy because it's looking for the emoji as the last comment https://github.com/Expensify/App/runs/3258161442?check_suite_focus=true

[Jag96]