Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update company address label text #4301

Merged
merged 2 commits into from
Jul 29, 2021
Merged

[No QA] Update company address label text #4301

merged 2 commits into from
Jul 29, 2021

Conversation

mountiny
Copy link
Contributor

Details

Just a simple change of updating the copy of one input label when user enters Company address in VBA flow.
Discussion about the translation is here.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/172247

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

simulator_screenshot_4B400E18-4EDE-4FDC-83C1-D3D713A86592

Desktop

iOS

Android

@mountiny mountiny self-assigned this Jul 29, 2021
@mountiny mountiny requested a review from a team as a code owner July 29, 2021 15:48
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team July 29, 2021 15:48
@ctkochan22 ctkochan22 merged commit 6595c6b into main Jul 29, 2021
@ctkochan22 ctkochan22 deleted the vit-fixPOBoxCopy branch July 29, 2021 23:33
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants