Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send emailList as string when removing from workspace #4318

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Jul 30, 2021

Details

We're currently sending an array of strings to the API when removing a user from a workspace which isn't working on iOS (the API receives nothing). In the Web repo for the same command we send a comma-separated list of emails, and the API expects a comma-separated list as well, so this PR updates the usage here to be in line with our other usages.

Fixed Issues

$ #4299

Tests/QA

  1. Launch the app
  2. Click on FAB menu
  3. New Workspace
  4. Click on Get Started!
  5. Select People
  6. Invite 3 users to your workspace
  7. Select one of the users/ user and Click Remove
  8. Click Remove button on the Remove Members popup, confirm user is removed successfully

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Mobile

Web

@Jag96 Jag96 self-assigned this Jul 30, 2021
@Jag96 Jag96 requested a review from a team as a code owner July 30, 2021 01:01
@MelvinBot MelvinBot requested review from robertjchen and removed request for a team July 30, 2021 01:01
Copy link
Contributor

@robertjchen robertjchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@robertjchen robertjchen merged commit f856107 into main Jul 30, 2021
@robertjchen robertjchen deleted the joe-mobile-workspace-remove branch July 30, 2021 15:31
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants