Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for PR #4190 #4322

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Patch for PR #4190 #4322

merged 1 commit into from
Jul 30, 2021

Conversation

aman-atg
Copy link
Contributor

@aman-atg aman-atg commented Jul 30, 2021 •
edited
Loading

Details

Patch for PR #4190
( comment )

cc : @johnmlee101

Fixed Issues

$ #4155

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

prTest1.mp4

Mobile Web

prTest2.mp4

Desktop

iOS

Android

@aman-atg aman-atg requested a review from a team as a code owner July 30, 2021 15:11
@MelvinBot MelvinBot requested review from madmax330 and removed request for a team July 30, 2021 15:12
johnmlee101
johnmlee101 approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Jag96
Copy link
Contributor

Jag96 commented Jul 30, 2021

Adding CP to staging label to get this on staging so we can check it off the list. Also looks like the job for posting the Staging CP comment failed, so posting it below:

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@Jag96 Jag96 merged commit 0c49bcf into Expensify:main Jul 30, 2021
@Jag96 Jag96 mentioned this pull request Jul 30, 2021
Closed
71 tasks
github-actions bot pushed a commit that referenced this pull request Jul 30, 2021
@Jag96
Merge pull request #4322 from aman-atg/aman-atg-minorFixFor#4190
2a54315 
Patch for PR #4190

(cherry picked from commit 0c49bcf)
@OSBotify OSBotify mentioned this pull request Jul 30, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jul 30, 2021
Closed
100 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@aman-atg aman-atg deleted the aman-atg-minorFixFor#4190 branch July 30, 2021 20:05
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Aug 6, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
This was referenced Aug 25, 2021
Closed
Closed
This was referenced Sep 2, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@johnmlee101 johnmlee101 johnmlee101 approved these changes

@madmax330 madmax330 Awaiting requested review from madmax330

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aman-atg @Jag96 @OSBotify @johnmlee101