Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle navigation when reportID isn't valid #4387

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

aman-atg
Copy link
Contributor

@aman-atg aman-atg commented Aug 2, 2021

Details

(comment)

Fixed Issues

$ #4319

Tests || ### QA Steps

  1. Login to new expensify
  2. Enter any letter after r/ in the URL
  3. You will be redirected to Concierge's Chat and a error msg will be shown

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

prWeb.mp4

Mobile Web

mWeb.mp4

Desktop

iOS

Android

@aman-atg aman-atg requested a review from a team as a code owner August 2, 2021 23:04
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team August 2, 2021 23:04
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, just added one comment about a potential improvement

src/pages/home/ReportScreen.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one request

src/pages/home/ReportScreen.js Show resolved Hide resolved
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jag96 Jag96 merged commit f4e86f3 into Expensify:main Aug 5, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants