Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misaligned text on Workspace Card Page #4396

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Fix misaligned text on Workspace Card Page #4396

merged 1 commit into from
Aug 5, 2021

Conversation

rdjuric
Copy link
Contributor

@rdjuric rdjuric commented Aug 3, 2021

Details

Changes the styling used in our button text so that it's aligned in all platforms.

Fixed Issues

$ #4338

Tests

  1. Open one of your workspaces
  2. The Manage Cards text should be correctly centered inside the button.

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web

Mobile Web

mWeb

Desktop

desktop

iOS

iOS

iOS - iPad

iPad

Android

android

@rdjuric rdjuric requested a review from a team as a code owner August 3, 2021 21:33
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team August 3, 2021 21:34
Copy link
Contributor

@jasperhuangg jasperhuangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great!

@jasperhuangg jasperhuangg merged commit 474a149 into Expensify:main Aug 5, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants