Handle undefined IOU Report on IOUdetails page #4534
Conversation
|
Please confirm the Translations. Thanks |
src/languages/en.js
Outdated
| @@ -336,8 +336,9 @@ export default { | |||
| createGroup: 'Create Group', | |||
| }, | |||
| notFound: { | |||
| chatYouLookingForCannotBeFound: 'The chat you are looking for cannot be found.', | |||
| chatYouLookingForCannotBeFound: 'The chat you are looking for can not be found.', | |||
There was a problem hiding this comment.
this shouldn't change. It should be,
The chat you are looking for cannot be found.
src/languages/en.js
Outdated
| getMeOutOfHere: 'Get me out of here', | ||
| iouReportNotFound: 'Payment details you are looking for can not be found.', |
There was a problem hiding this comment.
I would rephrase this to be,
The payment details you are looking for cannot be found.
|
@chiragsalian Changes done. |
|
@chiragsalian Friendly ping. |
|
Yup i've posted about the spanish copy in one of our slack channels and we haven't landed on a resolution. Shall update you as soon as i get an update. Let me bump them. |
src/languages/es.js
Outdated
| @@ -336,8 +336,9 @@ export default { | |||
| createGroup: 'Crear Grupo', | |||
| }, | |||
| notFound: { | |||
| chatYouLookingForCannotBeFound: 'No se pudo encontrar el chat que estabas buscando.', | |||
| chatYouLookingForCannotBeFound: 'No se pudo encontrar el chat que está buscando.', | |||
There was a problem hiding this comment.
Can you change this to,
El chat que estás buscando no se ha podido encontrar.
src/languages/es.js
Outdated
| getMeOutOfHere: 'Sácame de aquí', | ||
| iouReportNotFound: 'No se pudo encontrar los detalles de pago que está buscando.', |
There was a problem hiding this comment.
Can you change this to,
Los detalles del pago que estás buscando no se han podido encontrar.
src/languages/en.js
Outdated
| @@ -338,6 +338,7 @@ export default { | |||
| notFound: { | |||
| chatYouLookingForCannotBeFound: 'The chat you are looking for cannot be found.', | |||
| getMeOutOfHere: 'Get me out of here', | |||
| iouReportNotFound: 'Payment details you are looking for cannot be found.', | |||
There was a problem hiding this comment.
Also the change i suggested here earlier doesn't seem to be applied, Basically, i suggest that it begins with,
The
so the complete text looks like,
The payment details you are looking for cannot be found.
|
@chiragsalian Done. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @chiragsalian in version: 1.0.85-10 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
|
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
Details
Fixed Issues
$ Fixes #4362
Tests | QA Steps
for example:
http://localhost:8080/iou/details/68438375/rajatTested On
Screenshots
Web
iou.mp4