-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
track-expense and submit-expense deep links #45603
track-expense and submit-expense deep links #45603
Conversation
Progress update
|
Oh, do you know if this is also happening on staging? |
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb Chrome *android-mweb.mp4iOS: NativeiOS: mWeb Safari *ios-mweb.mp4MacOS: Chrome / Safari *web.movMacOS: Desktop *desktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reviewing, I noticed that the TrackExpensePage
had an issue when it comes to the TRACK_TRAINING_MODAL
.
The issue being : when navigating to the /track-expense
route, regardless of already ticking the box to not show the track training again and having the variable saved in onyx, until the hasSeenTrackTraining
onyx variable is loaded, it's undefined
-> which causes the TRACK_TRAINING_MODAL
to always be shown.
Note: This does not happen via FAB -> Track expense because the hasSeenTrackTraining
onyx variable is loaded by the time Track expense is opened from FAB.
Following our useOnyx
pattern, I added 3 change suggestion comments in order to fix the issue.
Once the issue is fixed I will double check and if @marcochavezf thinks we're good to go considering #45350 (comment), then I will Approve.
Thanks for your suggestions, I have applied it and it works fine now on showing the track training: New-Expensify.25.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! LGTM 🎉
Regarding the issue with error on the submit expense flow, after further testing it turns out it's related to StrictMode and only happens on local dev (more context in #45350 (comment)) -> therefore we can move forward here as there are no other functionality issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks guys, LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀
|
Details
Fixed Issues
$ #45350
PROPOSAL: #45350 (comment)
Tests
A. track-expense deep link (Test both logged in and not logged in)
B. submit-expense deep link (Test both logged in and not logged in)
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
N/A
Android: mWeb Chrome
track-expense & submit-expense logged in
Expensify-magic-sign-in-code-104591---jyotisa1616-gmail-com---Gmail.mp4
cant test not logged in since it redirects to not found page after login using ngrok
iOS: Native
N/A
iOS: mWeb Safari
track-expense & submit-expense logged in
RPReplay_Final1721810545.1.mp4
cant test not logged in since it redirects to not found page after login using ngrok
MacOS: Chrome / Safari
track-expense & submit-expense logged in
-1-New-Expensify.7.mp4
track-expense not logged in
New-Expensify.23.mp4
submit-expense not logged in
New-Expensify.24.mp4
MacOS: Desktop
N/A