Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update state picker component in VBA flow #4633

Merged
merged 5 commits into from
Aug 13, 2021
Merged

Update state picker component in VBA flow #4633

merged 5 commits into from
Aug 13, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Aug 12, 2021

Details

This PR updates the other usages of StatePicker, which was using the old Picker component instead of the new Expensipicker.

Fixed Issues

$ #4630

Tests

  1. Navigate to Profile->Workspace->Expensify Card->Get Started and fill out any values for the first form
  2. On the 2nd form, confirm the State dropdowns show properly

QA Steps

  1. Navigate to https://staging.new.expensify.com/bank-account/new and fill out the first form w/ any info
  2. On the 2nd form, confirm the State dropdowns show properly

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web Mobile Desktop
image image image

@Jag96 Jag96 requested a review from Luke9389 August 12, 2021 23:23
@Jag96 Jag96 requested a review from a team as a code owner August 12, 2021 23:23
@Jag96 Jag96 self-assigned this Aug 12, 2021
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team August 12, 2021 23:23
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

nickmurray47
nickmurray47 approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luke9389 Luke9389 merged commit 28eabfd into main Aug 13, 2021
@Luke9389 Luke9389 deleted the joe-state-picker-update branch August 13, 2021 18:56
github-actions bot pushed a commit that referenced this pull request Aug 13, 2021
@Luke9389
Merge pull request #4633 from Expensify/joe-state-picker-update
4244dd6 
Update state picker component in VBA flow

(cherry picked from commit 28eabfd)
This was referenced Aug 13, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Luke9389 in version: 1.0.85-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Luke9389 in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 25, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

This was referenced Sep 1, 2021
Closed
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmurray47 nickmurray47 nickmurray47 approved these changes

@Luke9389 Luke9389 Luke9389 approved these changes

Assignees

@Jag96 Jag96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jag96 @OSBotify @nickmurray47 @Luke9389