Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline errors to workspace modal #5560

Merged
merged 9 commits into from
Oct 6, 2021
Merged

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Sep 28, 2021

Details

  • Updates Workspace Invite page to use similar error handling to VBA flow.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/179369

Tests / QA Steps

  1. Create a workspace
  2. Navigate to the People tab for the workspace /workspace/<policyID>/invite
  3. Try to submit the form with no values in the Emails or phone numbers section
  4. Verify that an inline error appears under the field and the field if highlighted in red
  5. Verify there is a link to "Fix the errors" above the "Invite" button
  6. Enter something that is not an email or phone
  7. Verify that an inline error appears under the field and the field if highlighted in red
  8. Verify there is a link to "Fix the errors" above the "Invite" button
  9. Enter concierge@expensify.com and submit
  10. Verify that an inline error appears under the field and the field if highlighted in red
  11. Verify there is a link to "Fix the errors" above the "Invite" button
  12. Enter a valid email and verify you can invite a user
  13. Enter the invalid test phone number +1111111111
  14. Verify that the error returned appears above the Submit button
  15. Close the modal and reopen it
  16. Verify the error is no longer present

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

2021-10-04_10-49-28
2021-10-04_10-49-23
2021-10-04_10-49-09
2021-10-04_10-51-56

Mobile Web

2021-10-04_10-56-12

Desktop

2021-10-04_10-59-08

iOS

2021-10-04_11-03-25

Android

2021-10-04_11-16-23

@marcaaron marcaaron self-assigned this Sep 28, 2021
@marcaaron marcaaron changed the title [WIP] Add inline errors to workspace modal Add inline errors to workspace modal Oct 4, 2021
@marcaaron marcaaron marked this pull request as ready for review October 4, 2021 21:17
@marcaaron marcaaron requested a review from a team as a code owner October 4, 2021 21:17
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team October 4, 2021 21:17
@thienlnam thienlnam merged commit 19a6bc1 into main Oct 6, 2021
@thienlnam thienlnam deleted the marcaaron-inviteInlineError branch October 6, 2021 17:46
@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 7, 2021

🚀 Deployed to staging by @thienlnam in version: 1.1.6-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

isagoico commented Oct 8, 2021

This issue is failing this PR in Desktop #5727

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants