Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments page blank issue. #5663

Merged

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Oct 5, 2021

Details

Directly accessing bankName property on bankAccount.additionalData object causes the crash, because additionalData may be undefined sometimes. So done optional data handling using underscore library

Fixed Issues

$ #5601

Tests & QA Steps

  1. Open the new Expensify app, login with an account that has a bank account(s) linked.
  2. Go to Settings -> Payments
  3. Payments Page should work fine.

Tested On

Note: I don't have any accounts with bank account. So kindly test using the steps mentioned above

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner October 5, 2021 19:05
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team October 5, 2021 19:05
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this works well, just one request

src/pages/settings/Payments/PaymentMethodList.js Outdated Show resolved Hide resolved
@Jag96 Jag96 merged commit f3f478e into Expensify:main Oct 6, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 7, 2021

🚀 Deployed to staging by @Jag96 in version: 1.1.6-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally
Copy link

@Santhosh-Sellavel @Jag96 On what platforms do you want us to QA this PR on?

@Santhosh-Sellavel
Copy link
Collaborator Author

iOS, Android & web should be enough.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants