-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace pages copy changes and growl on save #5759
Conversation
Just need confirmation on one translation, requested here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and tests well - feel free to self-merge once that translation is confirmed
@nickmurray47 need another approval b/c I had to adjust the Spanish copy. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
(cherry picked from commit 8fd5aec)
🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.7-21 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
QA looks good! Only discrepancy I saw was in:
You'll notice it says "saved', which I actually think is better than what the test copy is looking for (since Aside from that, we are dealing with the "spanish curse", so I can't validate those copy changes. checking off deploy. |
I QA'd the Spanish side of this issue and it was a pass! I'm stuck in Spanish locale so couldn't QA everything. But I think we are good to check this off. |
🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀
|
🚀 Deployed to staging by @roryabraham in version: 1.1.7-25 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/180784
$ https://github.com/Expensify/Expensify/issues/180786
$ https://github.com/Expensify/Expensify/issues/180789
$ https://github.com/Expensify/Expensify/issues/180793
$ https://github.com/Expensify/Expensify/issues/180800
$ https://github.com/Expensify/Expensify/issues/180802
$ https://github.com/Expensify/Expensify/issues/180804
Tests / QA Steps
Settings
->Your workspace
General settings
and a menu item.General settings
General settings
, notEdit workspace
Default currency
drop-down has a lowercaseC
in currencyYour workspace settings were successfully chagned!
Settings
->Your workspace
->Reimburse receipts
Unlock next-day reimbursements
instead ofUnlock next day reimbursements
Settings
->Your workspace
->Send invoices
Send invoice
, rather thanSend invoices
Unlock online invoice collection
, rather thanUnlock online invoices collection
.Settings
->Your workspace
->Manage members
and verify that the page title saysManage members
, notMembers
.Settings
->Preferences
and change your preferred language to Español.Configuración
->Your workspace
->Configuración general
Configuración general
¡Tus configuraciónes del espacio de trabajo se han guardado correctamente!
.Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android