-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show growl when clicking on links in offline mode #5776
Conversation
|
When offline, if follow:
you get to a page with the text: "We’re taking a look at your information. You will be able to continue with next steps shortly." and without a button to go back on the top. This message is incorrect for this situation, right? Screen.Recording.2021-10-12.at.11.16.02.AM.mov |
Thanks, @aldo-expensify. The workspace creation is out-of-scope for this, yeah. You might want to bring it up in the N6 room on slack though. The issue with the bank account page is also out-of-scope and being discussed over here in slack. |
I guess this may be out of the scope, but leaving a comment to remember. The "Manage members" doesn't work well offline, members get added locally, but there is not feedback. Trying again results in an error of adding a member that is already there. Screen.Recording.2021-10-12.at.11.23.49.AM.mov |
Heh, yeah... I think most of our forms will have this problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, tested on web and works for me!
Show growl when clicking on links in offline mode (cherry picked from commit d66c278)
…5776 🍒 Cherry pick PR #5776 to staging 🍒
🚀 Cherry-picked to staging by @aldo-expensify in version: 1.1.7-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀
|
🚀 Deployed to staging by @aldo-expensify in version: 1.1.7-25 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/180868
Tests / QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android