Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load policy list when url from Linking.getInitialURL is not available #5868

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Load policy list when url from Linking.getInitialURL is not available #5868

merged 2 commits into from
Oct 15, 2021

Conversation

aldo-expensify
Copy link
Contributor

@aldo-expensify aldo-expensify commented Oct 15, 2021 •
edited by roryabraham
Loading

Details

The url parameter is null when passed to our callback (see Linking.getInitialURL) when we open NewDot without using deeplink.

See slack conversation https://expensify.slack.com/archives/C9YU7BX5M/p1634263597215200?thread_ts=1634173120.171900&cid=C9YU7BX5M

Not sure if this is a good solution or if it could have some unwanted side effect. @roryabraham cc

Fixed Issues

$ #5865

Tests / QA

  1. Create an account in OldDot in web
  2. Create a Free group policy in OldDot -> this will create a new Workspace in NewDot
  3. Do that a few times (3 times? :) )
  4. Log out of NewDot
  5. Log in in new Dot
  6. You should see the 3? workspaces you created

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@aldo-expensify aldo-expensify requested a review from a team as a code owner October 15, 2021 02:53
@aldo-expensify aldo-expensify removed the request for review from a team October 15, 2021 02:53
roryabraham
roryabraham requested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, actually I'm un-approving this because it breaks the OldDot -> NewDot transition.

@aldo-expensify
Copy link
Contributor Author

Sorry, actually I'm un-approving this because it breaks the OldDot -> NewDot transition.

How is it breaking it?

roryabraham
roryabraham approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I was mistaken and was running into an unrelated issue while testing this. Tested on iOS a few times and now it seems to be working consistently 👍

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham roryabraham merged commit 3aeb62f into main Oct 15, 2021
@roryabraham roryabraham deleted the aldo_fix-missing-workspace-mobile branch October 15, 2021 03:49
github-actions bot pushed a commit that referenced this pull request Oct 15, 2021
@roryabraham
Merge pull request #5868 from Expensify/aldo_fix-missing-workspace-mo…
2ba66cd 
…bile

(cherry picked from commit 3aeb62f)
This was referenced Oct 15, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@roryabraham
Copy link
Contributor

Verified this is fixed on iOS 🎉

@OSBotify OSBotify mentioned this pull request Oct 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@NikkiWines NikkiWines Awaiting requested review from NikkiWines

Assignees

@aldo-expensify aldo-expensify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aldo-expensify @OSBotify @roryabraham