Fix: list is cut off at bottom in LHN

[parasharrajat]

Details

Fixed Issues

$ #5005

Tests | QA Steps

1. Open LHN on IOS.
2. Check the LHN should not hide behind the bottom home bar.

Please test #3637 as well which will be directly affected by this PR.

Tested On

• Web
• Mobile Web
• Desktop
• iOS [Affected Platfrom]
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

output_file.mp4

Android

[iwiznia]

Looks good, ping me after the tests

[parasharrajat]

@iwiznia I have done my testing. Added video only for IOS as only index.ios.js file is changed.

[parasharrajat]

I just found that the change I have removed has nothing to do with #3637. Clicking on view Details open the Modal Screen which is a screen on Stack navigator. and the Modal component is not used for that at all. It is used for Confirm, Dropdowns, Fab Menu, etc.

[parasharrajat]

@iwiznia I think we can move to the merge.

[parasharrajat]

@iwiznia Could you please review this?

[parasharrajat]

Gentle Bump... I am getting impatient here. There is another step on my proposal after this PR but we can't test that until this is merged.

@iwiznia

[iwiznia]

Sorry I was OOO on monday and worked half day yesterday.

I just found that the change I have removed has nothing to do with #3637.

But allegedly the changes in this PR #3709 which says Fixes #3637 introduced the changes and solved the problem. The issue also says:

incorrectly positioned in some iOS versions

Did you test in the correct iOS versions? (not sure which ones those are). Probably @rdjuric should know

[parasharrajat]

Yeah, I tested on the exact platform which QA has mentioned on the Issue.

But allegedly the changes in this PR #3709 which say Fixes #3637 introduced the changes and solved the problem. The issue also says

let me prove it to you.

The issue reported was coming on the IOU Details Page. and the changes done on that PR were related to BaseModal. BaseModal is used for Confirm Modals and contextMenu, attachment view, etc.

on the other hand, IOUDetails Modal uses React-navigation stack navigator to create the page and it does not utilize the BaseModal in anyways. So I find it hard to believe that changes and issue were related.
cc: @iwiznia

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @iwiznia in version: 1.1.8-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅