Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Cannot Remove Yourself banner shown again and again problem while inviting new member #6542

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

PrashantMangukiya
Copy link
Contributor

@johnmlee101 PR is ready for review.

Details

“Cannot remove yourself from workspace” banner is shown over and over again while inviting a new member, so within this pr corrected that problem.

Fixed Issues

$ #6287

Tests | QA Steps

  1. Navigate to add member screen.
  2. Tap on check box against own account once.
  3. Now tap on invite button to invite a new member
  4. The banner keeps on popping up.
  5. Even sending app to background and resuming or swiping down from notification panel also shows same behaviour.

QA Check: Within this pr we corrected this issue so it will not show Cannot Remove Yourself ... banner again and again.

Note: This issue occurring for iOS, Android and MobileWeb only. Web and Desktop has different behaviour as shown in screenshot so this issue not applicable for Web and Desktop.

Note: Within iOS and Android screen recording it will not show gap at left and right of the Growl message (i.e. Growl message touch at left and right of screen). Please ignore it because it is different issue #6530

Tested On

  • iOS
  • Android
  • Mobile Web
  • Web
  • Desktop

Screenshots

iOS

iOS.mov

Android

Android.mp4

Mobile Web

MobileWeb.mov

Web

Web

Desktop

Desktop

@PrashantMangukiya PrashantMangukiya requested a review from a team as a code owner November 30, 2021 16:58
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team November 30, 2021 16:58
@johnmlee101
Copy link
Contributor

Looks good to me!

@johnmlee101 johnmlee101 merged commit 52fb3ea into Expensify:main Nov 30, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @johnmlee101 in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

isagoico commented Dec 7, 2021

This issue is failing QA for Android and iOS #6528

@marcaaron
Copy link
Contributor

This issue is failing QA for Android and iOS

To confirm, the "Manage Members" page is also blank on iOS? Or just Android?

@isagoico
Copy link

isagoico commented Dec 7, 2021

We are experiencing this issue on both iOS and Android

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants