Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scrolling for Report Group Details Page #6555

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Conversation

ctkochan22
Copy link
Contributor

@Expensify/pullerbear
@TomatoToaster @jasperhuangg (suggested by github)

Details

If you go to a group's details page, the page is not scrollable. This is an issue if you go to that page on mobile, and rotate to landscape. You need to scroll to get to members:
SfslPPLTCa

Fixed Issues

$ GH_LINK

TestsQA

Have a report group made. I had to create a new account/domain for it to show up.

  1. Go to group
  2. Click on the group title for details
  3. Rotate to landscape
  4. Scroll down, verify that you can

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@ctkochan22 ctkochan22 requested a review from a team December 1, 2021 05:56
@ctkochan22 ctkochan22 self-assigned this Dec 1, 2021
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team December 1, 2021 05:56
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #6495 (comment) can you update the Details page as well?

@ctkochan22 ctkochan22 requested a review from a team as a code owner December 1, 2021 22:23
@MelvinBot MelvinBot requested review from deetergp and removed request for a team December 1, 2021 22:23
@ctkochan22
Copy link
Contributor Author

Updated

@deetergp
Copy link
Contributor

deetergp commented Dec 2, 2021

#waystar.com I know what you've been watching 😂

Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy breezy!

@Jag96 Jag96 merged commit fa46930 into main Dec 2, 2021
@Jag96 Jag96 deleted the ckt_fix_reportDetailsScrll branch December 2, 2021 00:19
@OSBotify
Copy link
Contributor

OSBotify commented Dec 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @Jag96 in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants