Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhoneX SafeArea regression fix #6559

Merged
merged 1 commit into from
Dec 2, 2021
Merged

iPhoneX SafeArea regression fix #6559

merged 1 commit into from
Dec 2, 2021

Conversation

kakajann
Copy link
Contributor

@kakajann kakajann commented Dec 2, 2021

Details

Fixed my regression on iPhoneX SafeArea

Fixed Issues

$ #6530
$ #5926

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Screen Shot 2021-12-02 at 11 05 23 AM

Android

@kakajann kakajann requested a review from a team as a code owner December 2, 2021 06:06
@MelvinBot MelvinBot requested review from deetergp and removed request for a team December 2, 2021 06:06
@kakajann
Copy link
Contributor Author

kakajann commented Dec 2, 2021

cc @parasharrajat @Julesssss

@kakajann kakajann closed this Dec 2, 2021
@kakajann kakajann reopened this Dec 2, 2021
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

All yours @deetergp

@Julesssss
Copy link
Contributor

@deetergp I'm merging this for #urgency as it's a regression.

@Julesssss Julesssss merged commit 5abed24 into Expensify:main Dec 2, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Dec 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @Julesssss in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants