Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Details and Settings for User Created Policy Rooms #7028

Merged
merged 68 commits into from
Jan 12, 2022
Merged

Report Details and Settings for User Created Policy Rooms #7028

merged 68 commits into from
Jan 12, 2022

Commits on Jan 4, 2022

  1. Add skeleton for Policy Rooms Details Page items

    Amal Nazeem committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    43379fd View commit details
    Browse the repository at this point in the history

  2. Add report settings route

    Amal Nazeem committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    1be77c7 View commit details
    Browse the repository at this point in the history

  3. Add copy for leaving a chat room

    Amal Nazeem committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    06b5357 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Use SignOut icon for leaving the room

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    82918f0 View commit details
    Browse the repository at this point in the history

  2. Use placeholders for functionality that will come in later issues

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    df53b7c View commit details
    Browse the repository at this point in the history

  3. Allow us to properly see when there are 0 other members in a policy room

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    4311da5 View commit details
    Browse the repository at this point in the history

  4. Add routes for report settings

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    a842885 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:Expensify/App into amal-policy-room… 

    …s-details-page
    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    8581def View commit details
    Browse the repository at this point in the history

  6. Rename SignOut to Exit to be more universally used

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    d5eac97 View commit details
    Browse the repository at this point in the history

  7. Fix alphabetical ordering

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    a20785a View commit details
    Browse the repository at this point in the history

  8. Remove typo extra line

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    1b7ef56 View commit details
    Browse the repository at this point in the history

  9. Create skeleton SettingsPage

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    bddeb9e View commit details
    Browse the repository at this point in the history

  10. Fix imports

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    e3962db View commit details
    Browse the repository at this point in the history

  11. Fix spacing

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    9f10475 View commit details
    Browse the repository at this point in the history

  12. Add onyx props and definitions

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    f556532 View commit details
    Browse the repository at this point in the history

  13. Add Report Settings to modal stack

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    75e9fc4 View commit details
    Browse the repository at this point in the history

  14. lint fixes for space styling and imports

    Amal Nazeem committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    5ed8498 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Fix blank menu items for default rooms

    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    bcb5e99 View commit details
    Browse the repository at this point in the history

  2. Move Notification Preferences to Report Settings Page for UCPRs

    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    0459d03 View commit details
    Browse the repository at this point in the history

  3. Add route propTypes to new component

    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    7dee263 View commit details
    Browse the repository at this point in the history

  4. Create Notification Preferences component

    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    f5815da View commit details
    Browse the repository at this point in the history

  5. Use NotificationPreferences component and remove redundant code

    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    775cc93 View commit details
    Browse the repository at this point in the history

  6. Fix style and use correct imports

    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    7933796 View commit details
    Browse the repository at this point in the history

  7. Add title into component

    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    84da563 View commit details
    Browse the repository at this point in the history

  8. Add description in notification preferences and reorganize translation

    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    4db2921 View commit details
    Browse the repository at this point in the history

  9. Fix weird margins for SettingsPage

    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    f10df0c View commit details
    Browse the repository at this point in the history

  10. Add spanish translation for notification preferences

    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    bbd1d4d View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' of github.com:Expensify/App into amal-policy-room… 

    …s-details-page
    Amal Nazeem committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    7faba99 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Remove unneeded Notification Preferences

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    aae68ad View commit details
    Browse the repository at this point in the history

  2. Move NotificationPrefences to Settings and set up view

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    747b705 View commit details
    Browse the repository at this point in the history

  3. Disable rename for defaultRooms and archived rooms

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    440a8a7 View commit details
    Browse the repository at this point in the history

  4. Add in report name and prevent renaming for default and archived rooms

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    f5edbbd View commit details
    Browse the repository at this point in the history

  5. Rework into class component to use room name changing

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    d127b85 View commit details
    Browse the repository at this point in the history

  6. Rework room name renaming to work like in NewRoomPage

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    c591f0d View commit details
    Browse the repository at this point in the history

  7. Use substring instead of deprecated substr

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    82912cc View commit details
    Browse the repository at this point in the history

  8. Include policy details to correctly display Workspace Name

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    d55a47c View commit details
    Browse the repository at this point in the history

  9. Style fix

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    86ccf4e View commit details
    Browse the repository at this point in the history

  10. Add visibility information

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    61bca31 View commit details
    Browse the repository at this point in the history

  11. Add visibility to simplifiedReportData so it can be used

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    066ff33 View commit details
    Browse the repository at this point in the history

  12. Add rest of visibility information to Settings component

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    9e1aabd View commit details
    Browse the repository at this point in the history

  13. Fix report visibility description and style

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    776050a View commit details
    Browse the repository at this point in the history

  14. Lint style fix

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    cde74ff View commit details
    Browse the repository at this point in the history

  15. Allow Buttons to have custom styles on the OpacityView to configure h… 

    …eight
    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    bfe3e1d View commit details
    Browse the repository at this point in the history

  16. Add styles for inner part of button in ReportSettingsPage

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    a11bd00 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'main' of github.com:Expensify/App into amal-policy-room… 

    …s-details-page
    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    6454645 View commit details
    Browse the repository at this point in the history

  18. Add context to how report visibility is being used

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    877c733 View commit details
    Browse the repository at this point in the history

  19. Move propTypes to appropriate location

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    b07962e View commit details
    Browse the repository at this point in the history

  20. Remove unused values

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    f3b0b26 View commit details
    Browse the repository at this point in the history

  21. Remove unsued View and reorganize styles

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    39c2a5e View commit details
    Browse the repository at this point in the history

  22. Add RoomNameInput component to consolidate room naming component

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    5e10c08 View commit details
    Browse the repository at this point in the history

  23. Use new RoomNameInput component

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    763af4a View commit details
    Browse the repository at this point in the history

  24. Make RoomNameInput functional with the ReportSettingsPage

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    fb11343 View commit details
    Browse the repository at this point in the history

  25. lint fixes/ cleaning up unused code

    Amal Nazeem committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    04fc0cc View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2022

  1. Make RoomNameInput work with WorkspaceNewRoomPage

    Amal Nazeem committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    a8b8fe3 View commit details
    Browse the repository at this point in the history

  2. lint import

    Amal Nazeem committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    18552c1 View commit details
    Browse the repository at this point in the history

  3. Make this work with actual policies and room names

    Amal Nazeem committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    a9e062d View commit details
    Browse the repository at this point in the history

  4. Better error checking with bubbling up to the top

    Amal Nazeem committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    6ae4a2b View commit details
    Browse the repository at this point in the history

  5. Fix error checking cases

    Amal Nazeem committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    2946b30 View commit details
    Browse the repository at this point in the history

  6. Fix error when nothing is changed in RoomSettingsPage

    Amal Nazeem committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    1554534 View commit details
    Browse the repository at this point in the history

  7. Clean up Onyx Props and comments

    Amal Nazeem committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    61af6c8 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Use styles to capitalize instead to better futureproof

    Amal Nazeem committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    ea6832c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:Expensify/App into amal-policy-room… 

    …s-details-page
    Amal Nazeem committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    698ae3f View commit details
    Browse the repository at this point in the history

  3. Remove unneeded extra newlines

    Amal Nazeem committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    ede4c29 View commit details
    Browse the repository at this point in the history

  4. Use ternary to simplify error logic

    Amal Nazeem committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    2130aff View commit details
    Browse the repository at this point in the history

  5. Keep originalRoomName out of state to avoid react/no-access-state-in-… 

    …setstate
    Amal Nazeem committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    730cb46 View commit details
    Browse the repository at this point in the history

  6. Use return early style instead and clear up comments

    Amal Nazeem committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    9a03719 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of github.com:Expensify/App into amal-policy-room… 

    …s-details-page
    Amal Nazeem committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    4545fb7 View commit details
    Browse the repository at this point in the history

  8. Rename buttonStyles to innerStyles

    Amal Nazeem committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    6ddfd43 View commit details
    Browse the repository at this point in the history