Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] update PR review checklist #7897

Merged
merged 13 commits into from
Mar 3, 2022
Merged

Conversation

marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Feb 24, 2022

Details

This PR updates the checklist template for Contributors and Reviewers. The changes are based on this convo.

Fixed Issues

N/A

Tests

N/A

QA Steps

N/A

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

N/A

@marcochavezf marcochavezf self-assigned this Feb 24, 2022
@marcochavezf marcochavezf marked this pull request as ready for review March 2, 2022 18:37
@marcochavezf marcochavezf requested a review from a team as a code owner March 2, 2022 18:37
@MelvinBot MelvinBot requested review from deetergp and removed request for a team March 2, 2022 18:37
@marcochavezf marcochavezf changed the title update PR review checklist [No QA] update PR review checklist Mar 3, 2022
@marcochavezf marcochavezf merged commit 1d57b79 into main Mar 3, 2022
@marcochavezf marcochavezf deleted the marco-prReviewChecklist branch March 3, 2022 20:16
@OSBotify
Copy link
Contributor

OSBotify commented Mar 3, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcochavezf in version: 1.1.42-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants