Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA][CP Stg] Export ELECTRON_ENV to electronBuilder.config.js #8000

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

roryabraham
Copy link
Contributor

Details

npm run desktop-build-staging -- --publish always (as executed here) is deploying the desktop app to production 😬

More context here

Fixed Issues

$ #7987

Tests

No way to test locally. Merge this PR and the desktop app should deploy to the staging S3 bucket.

QA Steps

None.

@roryabraham roryabraham requested a review from a team as a code owner March 4, 2022 03:16
@roryabraham roryabraham self-assigned this Mar 4, 2022
@roryabraham roryabraham changed the title [No QA] Export ELECTRON_ENV to electronBuilder.config.js [No QA][CP Stg] Export ELECTRON_ENV to electronBuilder.config.js Mar 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team March 4, 2022 03:17
@kidroca
Copy link
Contributor

kidroca commented Mar 4, 2022

Shouldn't we do something about this:
#7996 (comment)

There's no point building for 3 platforms if they overwrite themselves
Whatever platform finishes last would get uploaded as NewExpensify.dmg

@roryabraham
Copy link
Contributor Author

It seems like each platform create and overwrite the same file

I think you're right. Fortunately it's the universal that's uploaded last, so we should be okay in the meantime. We can follow-up with a separate issue. Maybe we can use some Cloudflare magic to deliver the correct app version based on user-agent.

@roryabraham roryabraham merged commit 3998980 into main Mar 4, 2022
@roryabraham roryabraham deleted the Rory-DesktopDeployEnv branch March 4, 2022 03:24
OSBotify pushed a commit that referenced this pull request Mar 4, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Mar 4, 2022

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.41-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants