Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Parse JSON of DO_CHERRY_PICK #8081

Merged
merged 1 commit into from
Mar 11, 2022
Merged

[No QA] Parse JSON of DO_CHERRY_PICK #8081

merged 1 commit into from
Mar 11, 2022

Conversation

roryabraham
Copy link
Contributor

Details

Fixes an oops

Fixed Issues

$ https://expensify.slack.com/archives/C03V9A4TB/p1646960145849389

Tests

  1. Merge with checklist unlocked.
  2. A staging deploy should occur and an attempted CP should not.

@roryabraham roryabraham requested a review from a team as a code owner March 11, 2022 01:13
@roryabraham roryabraham self-assigned this Mar 11, 2022
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team March 11, 2022 01:13
@francoisl francoisl merged commit 4a66aa8 into main Mar 11, 2022
@francoisl francoisl deleted the Rory-FixPreDeployBadCP branch March 11, 2022 01:43
@OSBotify OSBotify mentioned this pull request Mar 11, 2022
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @francoisl in version: 1.1.42-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@SumitDiyora SumitDiyora mentioned this pull request Apr 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisl francoisl francoisl approved these changes

@marcochavezf marcochavezf Awaiting requested review from marcochavezf

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roryabraham @OSBotify @francoisl