Revert iOS Safari auto scrollback #8571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roryabraham What is the next step for this? Are we going to revert it or something else? |
|
Hmmm ... I don't remember why I closed this. It might have been accidental. I think we do want to revert this auto scrollback feature. Do you agree? |
|
Yeah, I agree to revert it. |
|
I think we should proceed with this. It is creating more issues. |
# Conflicts: # src/libs/iOSSafariAutoScrollback/index.web.js
|
Opened up for reviews. |
ctkochan22
approved these changes
May 5, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
64 tasks
|
🚀 Deployed to staging by @roryabraham in version: 1.1.58-0 🚀
|
|
🚀 Deployed to production by @AndrewGable in version: 1.1.60-3 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR reverts #6413, which never really worked as expected and caused #8135.
There was a lot of context and conversation behind these changes. Reverting this PR will bring back this bug, which I think is the lesser of two evils (not as bad as #8135, which actually affects the usability of our app).
There was discussion of another solution, but I think we can reopen #5894 and make it external so they can figure out how to make it work with the address bar on top or bottom (which is a configurable setting as of iOS 15).
Fixed Issues
$ #8135
Tests / QA Steps
None, this is just a revert.