Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MacOS app download link to be copy from Right Hand fix #9047

Conversation

Justicea83
Copy link
Contributor

@Justicea83 Justicea83 commented May 17, 2022

Details

Fixed Issues

$ #8933

Tests

  • Sign in to NewDot.
  • Click on your profile picture.
  • Navigate to About > App download links.
  • On Web or Destop right click on any of the list items.
  • On iOS and Android long press on any of the list items.
  • Confirm from the screenshots below.

PR Reviewer Checklist

  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn’t already exist
    • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

  • Sign in to NewDot.
  • Click on your profile picture.
  • Navigate to About > App download links.
  • On Web or Destop right click on any of the list items.
  • On iOS and Android long press on any of the list items.
  • Confirm from the screenshots below.

Screenshots

Web

Screenshot 2022-05-17 at 12 41 54 PM

Mobile Web

Screenshot 2022-05-17 at 12 42 49 PM

Desktop

Screenshot 2022-05-17 at 12 45 17 PM

iOS

Screenshot 2022-05-17 at 12 53 37 PM

Android

Screenshot 2022-05-17 at 1 03 49 PM

@Justicea83 Justicea83 requested a review from a team as a code owner May 17, 2022 13:12
@Justicea83 Justicea83 self-assigned this May 17, 2022
@melvin-bot melvin-bot bot requested review from MonilBhavsar and removed request for a team May 17, 2022 13:12
@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented May 18, 2022

Also while testing on Android, I'm getting this error
Edit: Maybe caching issue, Doesn't appear after reloading the app

Screenshot 2022-05-18 at 5 50 39 PM

@MonilBhavsar MonilBhavsar requested a review from a team May 18, 2022 12:26
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team May 18, 2022 12:27
@MonilBhavsar
Copy link
Contributor

Requesting another reviewer

@Justicea83
Copy link
Contributor Author

Gentle bump

Copy link
Contributor

@techievivek techievivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me I am just concerned if we need to have any visual change as well otherwise the default thinking would be to click the item right? as it also has an external link icon so how would user now if they have an option of long press/right-click to copy the link?
Screenshot 2022-05-19 at 8 19 19 PM
In old dot in reports once we hover over the name it shows a tooltip that one can copy the email by clicking on the name. Is there something similar on new dot?

@techievivek
Copy link
Contributor

Or maybe something like this?
Screenshot 2022-05-19 at 8 22 02 PM

@Justicea83
Copy link
Contributor Author

@techievivek this is a typical example. Since we already have this flow, it's not advisable to do something different.

Screenshot 2022-05-19 at 4 36 04 PM

Copy link
Contributor

@techievivek techievivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then. Looks good from my end. Thanks

@Justicea83 Justicea83 merged commit 2d0336b into main May 19, 2022
@Justicea83 Justicea83 deleted the justice-allow-macos-app-download-link-to-be-copy-from-right-hand branch May 19, 2022 16:39
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Justicea83 in version: 1.1.64-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.64-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants