[No QA] Create OfflineUX.md file #9140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
PauloGasparSv
and removed request for
a team
Luke9389
commented
May 24, 2022
tgolen
previously requested changes
May 24, 2022
added 7 commits
May 24, 2022 17:13
… into luke-add-OfflineUX-md-file
iwiznia
previously requested changes
May 25, 2022
| - a form is used to make a WRITE request to the server and | ||
| - server has to do some validation of the parameters that can’t be done in the client or | ||
| - server response will be unknown so it cannot be done optimistically | ||
|
|
There was a problem hiding this comment.
Suggested change
| - If the request is moving money | |
| - If the request is related to security | |
Luke9389
requested review from
iwiznia,
tgolen,
marcochavezf,
yuwenmemon,
marcaaron and
roryabraham
roryabraham
requested changes
Jun 2, 2022
@roryabraham interesting stuff, but don't think we should block on it and can always update it later if people prefer this |
marcaaron
previously approved these changes
Jun 2, 2022
yuwenmemon
reviewed
Jun 3, 2022
Co-authored-by: Yuwen Memon <yuwen@expensify.com>
Co-authored-by: Yuwen Memon <yuwen@expensify.com>
|
Thx Yuwen! Committed those |
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
roryabraham
approved these changes
Jun 3, 2022
|
I'm gonna go ahead and self merge bc Marc, Yuwen, and Rory have all given overall 👍's or previously approved. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
47 tasks
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.73-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is the OfflineUX.md file, which will describe our Offline UX patterns and provide useful examples and resources for those seeking to implement them.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/211555