Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native attachments due to prop change #924

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Fix native attachments due to prop change #924

merged 1 commit into from
Dec 11, 2020

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Dec 11, 2020 •
edited
Loading

Think we might have missed this while testing #685

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/148107

Tests

  1. Open the app and login
  2. Search for users and add one of the member
  3. Click on attachment icon and take a picture
  4. Click on use photo
  5. Verify the photo is visible in the modal

Screenshots

Screen Shot 2020-12-11 at 10 46 26 AM

@marcaaron marcaaron self-assigned this Dec 11, 2020
@marcaaron marcaaron changed the title Fix native attachments do to prop change Fix native attachments due to prop change Dec 11, 2020
@marcaaron marcaaron marked this pull request as ready for review December 11, 2020 20:47
@marcaaron marcaaron requested a review from a team as a code owner December 11, 2020 20:47
@botify botify requested review from thienlnam and removed request for a team December 11, 2020 20:47
@marcaaron marcaaron removed the request for review from roryabraham December 11, 2020 21:50
@thienlnam thienlnam merged commit 0304ad6 into master Dec 11, 2020
@thienlnam thienlnam deleted the marcaaron-fixNativeAttachments branch December 11, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thienlnam thienlnam thienlnam approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcaaron @thienlnam