Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable inconsistency #1530

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix variable inconsistency #1530

merged 1 commit into from
Jul 7, 2023

Conversation

NikkiWines
Copy link
Contributor

Details

Fixes a minor nomenclature inconsistency I added in #1528

Fixed Issues

Fixes N/A

Tests

N/A doesn't change any logic, just a stylistic update.


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@NikkiWines NikkiWines requested a review from a team July 7, 2023 02:50
@NikkiWines NikkiWines self-assigned this Jul 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

I see this code uses list. If your primary use case is just checking to see if an item exists in the list, perhaps set is a better choice, as it's much faster for random access. C++ has a variety of data structures available to choose from, so pick the best for your use case.

@PauloGasparSv PauloGasparSv merged commit 28d1e40 into main Jul 7, 2023
2 checks passed
@PauloGasparSv PauloGasparSv deleted the nikki-fix-inconsistency branch July 7, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants