Add support for enterprise Google Maps accounts #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows you to pass `{ client: 'client', channel: 'channel' }` instead of
your API key (as well as providing versions if you wish through `{ key:
'apikey', v: '3.20' }`).
|
Sorry I've been on vaca. Thanks for the pull request. I'll merge in and publish to npm. |
mikkoh
added a commit
that referenced
this pull request
Sep 9, 2015
Add support for enterprise Google Maps accounts
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for enterprise Google Maps which don't use an API key, but instead use a client key and a trusted list of URLs. It also adds the ability (more or less by accident) to specify the version of the Google Maps library you wish to use by providing
{ key: 'apikey', v: '3.20' }instead of your API key.Support is implemented in a backwards compatible manner which accepts an object in place of the
apikeyparameter. This object is mapped to a URI query string using a.map().join()andencodeURIComponentwhich should be pretty robust and available on most systems.