Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in utils.ts #371

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix typo in utils.ts #371

merged 1 commit into from
Oct 3, 2023

Conversation

OzGav
Copy link
Contributor

@OzGav OzGav commented Sep 23, 2023

Fixed typo

@OzGav
Update utils.ts
ad14647 
Fixed typo
@OzGav OzGav changed the title Update utils.ts Fix typo in utility.ts Sep 23, 2023
@OzGav OzGav changed the title Fix typo in utility.ts Fix typo in utils.ts Sep 23, 2023
@exetico
Copy link
Member

exetico commented Oct 3, 2023

I will acknowledge that splitted is a non-standard word. Fair point.

But is "split" the right one? As the function has already done something, which it's trying to inform the user about. Let me know if you have another suggestion.

@OzGav
Copy link
Contributor Author

OzGav commented Oct 3, 2023

Yeah it’s one of the many weird words in English where the future and past tense of the verb is “split”. I will split the log, I have already split the log, I am splitting the log.

@exetico exetico merged commit 637ace5 into ExperienceLovelace:master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OzGav @exetico