Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another round of fixes #209

Merged
merged 5 commits into from
Mar 3, 2018
Merged

Another round of fixes #209

merged 5 commits into from
Mar 3, 2018

Conversation

XVincentX
Copy link
Member

@XVincentX XVincentX commented Mar 3, 2018

Connect #208
Closes #208

Connect #207
Closes #207

image

@XVincentX XVincentX requested a review from altsang March 3, 2018 16:21
@@ -2,7 +2,7 @@
title: 'Developer Spotlight: Compare Amazon API Gateway vs Express Gateway'
date: 2018-02-02 00:00:00 Z
categories:
- comparision
- comparison
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we use plural like announcements, just to keep consistent - comparisons?

<p><a href="https://vimeo.com/256160092">How To Use Environment Variables In Express Gateway</a> from <a href="https://vimeo.com/altsang">Al Tsang</a> on <a href="https://vimeo.com">Vimeo</a>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be from Vincenzo Chianese, not Al Tsang?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory yes; in practice I do not have a Vimeo account, so there's no link I could put.

How do you want me to handle this?

Copy link
Contributor

@altsang altsang Mar 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it's ok, I'm just the poster, the text can just be changed, all of our EG and LB videos are under my paid account

i.e.
from Vincenzo Chianese on <a href="https://vimeo.com/altsang">Vimeo</a>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants